MIME-Version: 1.0
References: <20211228030924.3468439-1-xianting.tian@linux.alibaba.com> <8a7f84b6-8d63-0005-754b-cfd158c8952e@linux.alibaba.com>
In-Reply-To: <8a7f84b6-8d63-0005-754b-cfd158c8952e@linux.alibaba.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Tue, 4 Jan 2022 14:18:12 +0800
Message-ID: <CACGkMEsA+b_YSa7ASww7qDM3f-4q39qGEa0Gyu5qXTvTeW-odg@mail.gmail.com>
Subject: Re: [PATCH] vhost/test: fix memory leak of vhost virtqueues
To:     Xianting Tian <xianting.tian@linux.alibaba.com>
Cc:     mst <mst@redhat.com>, kvm <kvm@vger.kernel.org>,
        virtualization <virtualization@lists.linux-foundation.org>,
        netdev <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jan 4, 2022 at 1:59 PM Xianting Tian
<xianting.tian@linux.alibaba.com> wrote:
>
> hi
>
> Could I get your comments for this patch?  it fixed the memleak issue.
>
> =E5=9C=A8 2021/12/28 =E4=B8=8A=E5=8D=8811:09, Xianting Tian =E5=86=99=E9=
=81=93:
> > We need free the vqs in .release(), which are allocated in .open().
> >
> > Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> > ---
> >   drivers/vhost/test.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
> > index a09dedc79..05740cba1 100644
> > --- a/drivers/vhost/test.c
> > +++ b/drivers/vhost/test.c
> > @@ -166,6 +166,7 @@ static int vhost_test_release(struct inode *inode, =
struct file *f)
> >       /* We do an extra flush before freeing memory,
> >        * since jobs can re-queue themselves. */
> >       vhost_test_flush(n);
> > +     kfree(n->dev.vqs);
> >       kfree(n);
> >       return 0;
> >   }
>