Message-ID: <d485fb62-b576-f9b6-13bc-709a2c409240@gmail.com>
Date:   Tue, 4 Jan 2022 08:29:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20220104111551.7f26e893@canb.auug.org.au>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: linux-next: build failure after merge of the pm tree
In-Reply-To: <20220104111551.7f26e893@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04.01.2022 01:15, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_84 allmodconfig)
> failed like this:
> 
> sound/soc/sh/rz-ssi.c: In function 'rz_ssi_probe':
> sound/soc/sh/rz-ssi.c:1023:2: error: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Werror=unused-result]
>  1023 |  pm_runtime_resume_and_get(&pdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   877d952c261e ("PM: runtime: Annotate pm_runtime_resume_and_get() as __must_check")
> 
> This also produced the following warnings in my arm multi_v7_defconfig
> build:
> 
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_hw_init':
> drivers/crypto/stm32/stm32-hash.c:816:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>   816 |  pm_runtime_resume_and_get(hdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_import':
> drivers/crypto/stm32/stm32-hash.c:1003:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>  1003 |  pm_runtime_resume_and_get(hdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_export':
> drivers/crypto/stm32/stm32-hash.c:965:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>   965 |  pm_runtime_resume_and_get(hdev->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-cryp.c: In function 'stm32_cryp_hw_init':
> drivers/crypto/stm32/stm32-cryp.c:545:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
>   545 |  pm_runtime_resume_and_get(cryp->dev);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I have used the pm tree from next-20211224 for today.
> 
The patch in the pm tree annotating pm_runtime_resume_and_get() as __must_check
follows some fixes of pm_runtime_resume_and_get() usage that went through other
trees. These fixes are in linux-next but don't seem to be in the pm tree.
We talk about:
f04b4fb47d83 ("ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()")
3d6b661330a7 ("crypto: stm32 - Revert broken pm_runtime_resume_and_get changes")