From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: per-cpu rcuc kthread are created only when
 rcutree.use_softirq=0
Thread-Topic: [PATCH] rcu: per-cpu rcuc kthread are created only when
 rcutree.use_softirq=0
Thread-Index: AQHX+8Gg3pvzIsNS/E+4asoIGfkMTaxOZikAgALqwoCAABWoAIABGxDw
Date:   Tue, 4 Jan 2022 08:38:32 +0000
Message-ID: <PH0PR11MB58809470102F4519610B6BE3DA4A9@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20211228160510.2893362-1-qiang1.zhang@intel.com>
 <20220101164426.GA2408833@paulmck-ThinkPad-P17-Gen-1>
 <YdL3Vx6pq6YCL1kx@linutronix.de>
 <20220103143442.GG2408833@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20220103143442.GG2408833@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.200.16
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ATtf6AxCKfwaSA5OrDRfP1W7NW9rjzkVP5rrm356bBL/RbUySGsjLOn3yP7?=
 =?us-ascii?Q?Wb1zPfbK6ffdWUhwSzRoh4rz108Ay9iXIbxvinFtY5tsFw54wUJSXP+qAh8t?=
 =?us-ascii?Q?XyyO/oqBpPebbx3ccjPSde+nMSYLhGKZsEeP5ynuL/nJlMXu2ZbabROT4m3r?=
 =?us-ascii?Q?9GzDldT5APN2tB+S+VeDFpktnHcAwI0wQJDjvkp5tCzEeYK7s/OpnmsKlObz?=
 =?us-ascii?Q?6FtSXCQ0mUVdn+8iWhnGNs3BY3dobPq18jAUkefIsWy7cMUeJ0c52twc9rai?=
 =?us-ascii?Q?GoB/CcYBu5pJYsn7KQZJ7Fe9V84UNjEKk22vqTbYavkIGqCow5BQFQCFFWvZ?=
 =?us-ascii?Q?IQocsxLZHXTiMIOwvK1H8LS9u+3gjPfGS+vysgL8u37Nfdw5qxCEry/MtGpi?=
 =?us-ascii?Q?tKX1LJU5WUd6JPnwhvkPoEsB+kn1oV9IM7SSVKwWRFJ52n3qVOid+WSj1T9C?=
 =?us-ascii?Q?jzGUODyt0u7kQccK4HacqmBb0rUuR2YKXEX/o8Cav1LfvhD69PJbp2o56Qgk?=
 =?us-ascii?Q?fQr1CZvDBkAOtEFDHPFoEyYqrKtPpvw6MKVVN6Lw+o90CVWHj7q+V4NgilRT?=
 =?us-ascii?Q?SEY5nxe8tZLS19TUtEdAVl2IjKRYs+s7tvQ/hY8o11yT4Rnk63Z+6VTzTYyt?=
 =?us-ascii?Q?aCYanJe0sTQZHqZuIwErLqUHspXllO2VUYynp2wcFGVUecnmUqk0cmJAnp63?=
 =?us-ascii?Q?fPUOuedFXe51KMmTzyvC4vGs/hBwQGzMuP6O7KvH15Hyk7sRxtnL6Ni/EwXc?=
 =?us-ascii?Q?3n0pkIGLJ3C0nE1CIwh920TyKPigdhkKM4SEiPJ5Kay8fLPxd1boSEFk77Qy?=
 =?us-ascii?Q?ozZ875111BzOMK1Raxr0FNF7OC5dXlY71YACTl2DaucrRBIZI4q8Nhlqp2xL?=
 =?us-ascii?Q?WhzumSqT9MBT+IwZ2eiGSLciMw53X0BJulBjIPBLLY+2aGB26x6Ruou9f4K9?=
 =?us-ascii?Q?CgcPcdBtXXoJUGUfTpv+yk5CBFvabrE8ISY182HRFrXudQka7LHveEEwXmCN?=
 =?us-ascii?Q?sJZ0Q1P6vP1SuFTmo+GGhI0x5bZDiGHPL/erj+x3ik6eh8HFdiHnW/Lqeg4y?=
 =?us-ascii?Q?JzvYgoCrWcheoPxpDAw7I6ahbVD4oNGSGBLC7MF8UDmaXnZnQooukhjY80vZ?=
 =?us-ascii?Q?VQs3LrI3iBplMW97MbOGJ7ieLkfcIE3w/8lL7KRdzp66WXlDKHOeDNGQ2J9f?=
 =?us-ascii?Q?tXDAo91wdmp0T6g013CEMcq8uGt7fXuKd6l4TwueLLL5goWpVccGKbrOYC6a?=
 =?us-ascii?Q?Z4YaCuGUFUZjXjQK3IEcvaByI4fwTvNNLfGZqJQ6WqFrn7w+44t9aBtFIN1R?=
 =?us-ascii?Q?NxNXrEGQgpPp3tX7cezQpL2L40i7H1wFVM8DXI2NDnOSijhiqlLmBfesIn8B?=
 =?us-ascii?Q?n9M7/viIwWKOgxA7/SrR/rB8fNU9kxiyK1bALjacOfm1cMZb6/6dy8H+gTZv?=
 =?us-ascii?Q?nSjjx2+KUQAgwqAHLc98Kpy6iiQKTXtm3ZPNYeuYjmRQwiBQ0jQrdZcv/TXU?=
 =?us-ascii?Q?EGC24dvw1c1PAnUW6RwXDRFM9JKwp4fgjKMCwHti759PCMcHtw96GpOGPZdq?=
 =?us-ascii?Q?+Zft0oXG097a587l2UZX0kQSfs1dulg15KF2Ul5RbcqS7N62bwVZrNU8C3Dy?=
 =?us-ascii?Q?B4354uPLUTcfvF6DbN7Mo6A=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0e81acf-3055-4fef-abc9-08d9cf5d977a
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2022 08:38:32.9006
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Sj8fp7TBAOvd8RAq2U0ZQvhlvJGrMUXkj/dDf8lH3Cld1FruhLfriJ+fxNC0y/eFRu06eeGj2H9z+Th7uZ4BPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5942
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Mon, Jan 03, 2022 at 02:17:11PM +0100, Sebastian Andrzej Siewior wrote:
> On 2022-01-01 08:44:26 [-0800], Paul E. McKenney wrote:
> > On Wed, Dec 29, 2021 at 12:05:10AM +0800, Zqiang wrote:
> > > In non-RT kernel, if the RCU_BOOST is enabled, the per-cpu rcuc=20
> > > kthread will be created, however under the rcutree.use_softirq=3D1,=20
> > > the RCU core processing only in softirq context, the rcuc kthread=20
> > > doesn't do anything, so remove RCU_BOOST interference.
> > >=20
> > > Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> >=20
> > Looks sane to me, but adding Sebastian on CC for his thoughts.
>=20
> Yes, it makes sense. invoke_rcu_core_kthread() is only invoked for=20
> !use_softirq so it makes to create the threads based on this condition.
>=20
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Thanks Sebastian review.

>Thank you both!  As usual, I could not resist a bit of wordsmithing, pleas=
e see below.

Hi Paul , thank you for your modification, your description is clearer.

Thanks,
Zqiang

>
>							Thanx, Paul
>
>------------------------------------------------------------------------
>
>commit 6e68b781388cfaca95a07493a060c4a6e4ee5d0f
>Author: Zqiang <qiang1.zhang@intel.com>
>Date:   Wed Dec 29 00:05:10 2021 +0800
>
>    rcu: Create per-cpu rcuc kthreads only when rcutree.use_softirq=3D0
>   =20
>    The per-CPU "rcuc" kthreads are used only by kernels booted with
>    rcutree.use_softirq=3D0, but they are nevertheless unconditionally cre=
ated
>    by kernels built with CONFIG_RCU_BOOST=3Dy.  This results in "rcuc"
>    kthreads being created that are never actually used.  This commit
>    therefore refrains from creating these kthreads unless the kernel
>    is actually booted with rcutree.use_softirq=3D0.
   =20
>    Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>    Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
>diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index aeea5487632f7..5c=
0ffee7a43a0 100644
>--- a/kernel/rcu/tree.c
>+++ b/kernel/rcu/tree.c
>@@ -2903,7 +2903,7 @@ static int __init rcu_spawn_core_kthreads(void)
>=20
> 	for_each_possible_cpu(cpu)
> 		per_cpu(rcu_data.rcu_cpu_has_work, cpu) =3D 0;
>-	if (!IS_ENABLED(CONFIG_RCU_BOOST) && use_softirq)
>+	if (use_softirq)
> 		return 0;
> 	WARN_ONCE(smpboot_register_percpu_thread(&rcu_cpu_thread_spec),
>		  "%s: Could not start rcuc kthread, OOM is now expected behavior\n", __=
func__);