Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 12/40] x86/sev: Add helper for validating pages in
 early enc attribute changes
To:     Borislav Petkov <bp@alien8.de>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-13-brijesh.singh@amd.com> <YcRifo82cGk+wP+a@zn.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <31826b30-a320-8392-96ce-829b7216e588@amd.com>
Date:   Tue, 4 Jan 2022 09:33:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YcRifo82cGk+wP+a@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVNzdUhCbSt4UUtqdlFCVGxZSHJyd3NtUjlIQzU3WFY5OFpCNEpzYUxuaWR6?=
 =?utf-8?B?bE5BaHh4RmNlSmw0L29YcnRsQ2NMcDVxZU00aDloR1Z6TWkySk5JbFV6ajRK?=
 =?utf-8?B?ZlU5UVBLYmk3Nmt4eTdkQWdVclFGbmozVUFkYml1dlNHeEdMZlJiVTc1NGth?=
 =?utf-8?B?dzByUU9MRXZ6MXJGTi9TQyt2UUdDOU5Wd2RIbGFncmlmUms2QjlaUytYakQw?=
 =?utf-8?B?R1pORTd0UnhZdkI1QkpKL1IwOWRFVFBOVzdUMTE5blVnTmZISUlSMEJ3VEJR?=
 =?utf-8?B?U1c5RUtTOFJmN2p4SnZEeU1sYTlINVd3QTUxdW1QNXpCMGR0ZWIvdmxiQWk0?=
 =?utf-8?B?R0NoOTRMQWNST3lkaGFsOWRGVGFCMEc0elp2QVVHQWFpY3U2QVM4UWtDa1Ux?=
 =?utf-8?B?bGFnKzhrQVEwYmxTcFZ2WHk3a1ZrNkdTRHdTNnczSXpZL1JUcjIreldKenNR?=
 =?utf-8?B?dWZPbFBzczBTWjNFNWpvRWF6ZWFIUWJGRi8vd2huRFVXZklIUmlPMWZpYXdO?=
 =?utf-8?B?czV2TE5la3o0Vy94WjBrYnZ1TldadEZkUVBocVRTSnBvbEJMdmR5Z3Q0WFdx?=
 =?utf-8?B?aFVVNUd2Qm4zTGZjRkdyRFlIekdQbXR5eXlGNHdUVjZ4L1FjcnhXMWFSRFRl?=
 =?utf-8?B?YVpFNHQvcDBqUTJPcHdXckdPL1B3bjZCYlNXWUw1QzlrNFVlYTVoaCt3MkxZ?=
 =?utf-8?B?eFJIdjgzRkJJRXNBVE5MMWNoQzcxSTRBSm5JR01rS2docFdzbk1uSjlLaWpY?=
 =?utf-8?B?OFZPR0NZZFNoT0hWbDMxL0ViVGJObXdmY0JUYzBYbHV0cUlZazZ5aWdDMmRy?=
 =?utf-8?B?aSt4aE05T0RWcWsyOExWQTV4eVFFU0ZKVGVmNTFORE9UZWZ1NmQzYy92R1hn?=
 =?utf-8?B?QXR4V2p0czhUbUNKMHRUQVpuWitIeEZub0dGck9xZWRWMFA3UzNMUXh6d0xv?=
 =?utf-8?B?d21VMHoya2tWNE1TNW9sYU9VL2V1bzMxZ3hkejVqZGFhdG9sTThEV1htK1JO?=
 =?utf-8?B?bEVYZUFoNnBWck1pcTR6VmdOYVVGMWNLWDJ6YWxWRGJqeW44NFFhS1VGYUtQ?=
 =?utf-8?B?NnpQeHdkd1hScnppNzQ2QTJ4elJvL3FRdXlUalNVdlVRV3QxOVgxUHBERTlz?=
 =?utf-8?B?c2cwMlZPWHgyeUVXZjlqcFd4WHdmaUhURWJteXVwSEZrVElXZFFUNFcyL0J0?=
 =?utf-8?B?MCtBZGlMUVJPYmdhWDJkSE92U1ZwcmhHbDlSZGZVVnNGY2lOUkVwaEpjZ1dT?=
 =?utf-8?B?TWVQZS9lY2h0QlNIZy9DQVpFWHFRYzVHZDlVMzdCR2k0UU9ETGxNTnpWcWVU?=
 =?utf-8?B?WW54VUlKQnhwQTVvcm9WUlpERkpkSkhWbk5Bb3E1T2tGT3oxY2ZTclFwem04?=
 =?utf-8?B?MysrNXJzMzc1SWpPajdBa2s0ZXEyakRFMU1hTmV1K3dxL0VPOHI3NDNITEdp?=
 =?utf-8?B?TTlVZkYrcUZUbUU1NnRsWWJUbXBOMk5BYXZpT1U2Y0p6OFlEWEMvVW9CT3hE?=
 =?utf-8?B?Z0UxcTBabVRMOFlKVTEwdFhiWUtYVWdabHVEV0t6MWlyRTFmZzIwNFNZaFNz?=
 =?utf-8?B?NlJZblJ3c3ZaTk10M2dub3JUSTNrbVVzRlA5U3dLazZpem41TkdhYjhndi9L?=
 =?utf-8?B?ckh0dEo5a2krRkRSeFlEN2YyczRXNVZ0R1QrLzB0aXhWTGJYSk1MNW82YldL?=
 =?utf-8?B?UEJOdWN1Vy8xcnRqeGZHQzY3akw1U0dPVTZ5YlZZOC9pNlBqTmViaStTK1hP?=
 =?utf-8?B?WlZLTkZlOEZQdDNCN0QrZGZFVXNjMnFaM0NrZU1QZ1J1SVRLVkdkM0s2SEY1?=
 =?utf-8?B?MTVrc3ZrVGZhR2NLQnZQaUM0VFAwU04wbHlhRVBkS1ZRMlZWT3M0L0RkWUNj?=
 =?utf-8?B?UjJncGx0V2VKc0hQSzZmaXZmVmZ4L000ak13Mk5hQ3RMbUY0Zzk0V1Q3akhD?=
 =?utf-8?B?WUsySFBiQWxLUVBHcEhQcmY1WlBEWWUrTmpBYjJlV3NkNE5xYXA0NEVTRU5L?=
 =?utf-8?B?WG8vdHk4M1N4UmhUMVN6VUltd3orMTN1WHpTL2RtTElSeGx1ZitqTXpaSW5L?=
 =?utf-8?B?RFZCd2t1b0llWlduQmd1cW04dGRQTFhIOWxiU2wvTWxFUUkwd0hodUJ5QlZm?=
 =?utf-8?B?TEpPZVYwc0t4SnZuOVRlV24rY294Wk84NFR1OEVCK0Joemk3Tjl6TmlrVTFw?=
 =?utf-8?Q?7yt140JRxuZMflNVlV5QDZ4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c26f549-3feb-4c70-24db-08d9cf978ef5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 15:33:29.7476
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jAVRPpFGEiPHG9wgyyTnXrFSiuv0cdOh8W45s1Gw1Zy+oK/Qde9jKXkem7mfyZcxL64Z28tuXIYhouJ4H2cxtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2511
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/23/21 5:50 AM, Borislav Petkov wrote:
>> While at it, add a helper snp_prep_memory() that can be used outside
>> the sev specific files to change the page state for a specified memory
> 
> "outside of the sev specific"? What is that trying to say?
> 
> /me goes and looks at the whole patchset...
> 
> Right, so that is used only in probe_roms(). So that should say:
> 
> "Add a helper ... which will be used in probe_roms(), in a later patch."
> 

Currently the helper is used for the probe_roms() only but it can be 
used by others in future. I will go ahead and spell out saying that it 
is for the probe_roms().


> 
> Yeah, looking at this again, I don't really like this multiplexing.
> Let's do this instead, diff ontop:
> 

thanks, I will apply your diff.