MIME-Version: 1.0
References: <20220104153615.13393-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20220104153615.13393-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 4 Jan 2022 17:52:35 +0200
Message-ID: <CAHp75VcSQyPb8+5rGQ7=dZwTmstZy4JTJpxBJrjN35ghs2Ko4Q@mail.gmail.com>
Subject: Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Prabhakar <prabhakar.csengg@gmail.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 4, 2022 at 5:36 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.

Thanks, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> This patch depends on [1].
>
> [1] https://lkml.org/lkml/2021/12/22/633
> ---
>  drivers/gpio/gpio-rcar.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 437baecc434e..bd2e16d6e21c 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
>                 goto err0;
>         }
>
> -       if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> -                            IRQF_SHARED, name, p)) {
> +       ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> +                              IRQF_SHARED, name, p);
> +       if (ret) {
>                 dev_err(dev, "failed to request IRQ\n");
> -               ret = -ENOENT;
>                 goto err1;
>         }
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko