Message-ID: <d5a34c44-82e1-1d7c-1bb2-3fe257d6a572@intel.com>
Date:   Tue, 4 Jan 2022 09:38:44 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] dmaengine: ioatdma: use default_groups in kobj_type
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org
References: <20220104163330.1338824-1-gregkh@linuxfoundation.org>
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20220104163330.1338824-1-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/4/2022 9:33 AM, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the ioatdma sysfs code to use default_groups field which has
> been the preferred way since aa30f47cf666 ("kobject: Add support for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Dave Jiang <dave.jiang@intel.com>


> ---
>   drivers/dma/ioat/sysfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ioat/sysfs.c b/drivers/dma/ioat/sysfs.c
> index aa44bcd6a356..168adf28c5b1 100644
> --- a/drivers/dma/ioat/sysfs.c
> +++ b/drivers/dma/ioat/sysfs.c
> @@ -158,8 +158,9 @@ static struct attribute *ioat_attrs[] = {
>   	&intr_coalesce_attr.attr,
>   	NULL,
>   };
> +ATTRIBUTE_GROUPS(ioat);
>   
>   struct kobj_type ioat_ktype = {
>   	.sysfs_ops = &ioat_sysfs_ops,
> -	.default_attrs = ioat_attrs,
> +	.default_groups = ioat_groups,
>   };