Message-ID: <17df4307-ace8-8798-5bce-16f4843ed830@suse.com>
Date:   Tue, 4 Jan 2022 17:54:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen/x86: obtain upper 32 bits of video frame buffer
 address for Dom0
Content-Language: en-US
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>
References: <a3df8bf3-d044-b7bb-3383-cd5239d6d4af@suse.com>
 <bfab8ff9-9762-f90d-3f25-b57362f05b0b@oracle.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bfab8ff9-9762-f90d-3f25-b57362f05b0b@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDIzNmhiRWJBTGZJSWF4WlRyZ29RakVoUVhWdnZVNmRkLzZLWTZMY0FPVzNu?=
 =?utf-8?B?R0dJbDkyMENwN3hSdjB0VlkvRS9NYXRHVGVYaFZHVWltRVY2YXlQSktGSVVW?=
 =?utf-8?B?RDhnZ3hxVWY5STZhZi8rTHY4Z1FzUWJxSml2dTd3Wjk2R1VTbDdJWmhid1g5?=
 =?utf-8?B?eEpRQXJCcW5ZL3AvVFNtb3BFUW5Jc1QrT0FzcTNKNDJuaVBva0wwRzJsS2c4?=
 =?utf-8?B?N3JJTURrK0ZHV1VXbmRiZkZXSWxMZ1BCQVBUay9zNmc2WjVLV1RaTWZwZkx0?=
 =?utf-8?B?SWtwVmw2MlhKd1lHdzhhQWpUeEFPZjFPaVpjejNGMHVsa3p1R3F5T3hpTGlo?=
 =?utf-8?B?Tk1rYkV5eUlRaS9lcjdRQ2lveUZUdThDT0Z4ZVhONUQ2YitYUjdUb1krK0U0?=
 =?utf-8?B?c1FTUXFjekFOYjZqNjluWGpEYWdJL05Xc0cwSnpuVGFPMWhKNm5kVlB4blBR?=
 =?utf-8?B?bnhaa1ZOeWJ6MWw4dHBORWZWOGV5ZXVSWmh0V2VYb1YxdUJXVzZBN0lJb3Jw?=
 =?utf-8?B?MG9PQ2J4V0U4elFCR0FRaG5PRkhRbVFzaGdZQzNNM2ZQUGdKbHorV0tnbjdt?=
 =?utf-8?B?Vk5iUTZGZlZZcmk5cDg0L0YycGtyMHk0dGhnWTVYQmRSOXZSVStiQTZTcEVi?=
 =?utf-8?B?M0toQjRqQUhzNnZBM2xpTUN6M2hvYk1jMmNFZlNjYWtRWWNSaGVSaFRXMzlM?=
 =?utf-8?B?ZVJlNjBTUyttcEcwTUtLNjkvS3B5amRoekEyWmR6NENlc2Fmb0hDOHBGbys4?=
 =?utf-8?B?Z1VVU3orMVkxSGZpTGhsQTRkazJKTnVPMVdFVTM1OUNsUlhZd0loMTRWRWZZ?=
 =?utf-8?B?SlZtcHJwb1lBNDlEbE5uQWpuNUtjNlRHK29WSFBEaXhTUTRIaHhOOUlDemVW?=
 =?utf-8?B?bUYrNnVtS1Jid1RXQ1dpNDFkK0VvREVoTTJPM2hVaTludFZkUVVMOW5HOUND?=
 =?utf-8?B?VXdSNlNQV1pSR0g5L2tURXVzZFVtYzIzVWJ3QzJLTDZYbTVKNDUzUE5ENmxw?=
 =?utf-8?B?cjZhbUVzckRtdVNLVDJDdHJUWlFoWFVxdjd2VmlxNXpJQ29NSXFpVmxtTjJX?=
 =?utf-8?B?aGZhQlRGdHVuSW8rM2NGblN3dE5hUm1vTUlxVTNDTytDUDZYUmpaVjZKR3Mx?=
 =?utf-8?B?NDQ1UndyN3hvbzh6Z0FMWmxzKzc3dFBlSVorQzgwckM1VEJhQ1RvWkNwUEpq?=
 =?utf-8?B?L2JDYTNjenRtMERzZnU2cWxZS0VBWDFVdVBWUlZmbHg5a0tsUkl3dDlFTXVP?=
 =?utf-8?B?Q1RxR3Q5MnJvTVZGb1FTbG9kYkt4MDQ3RFZQcHZBd3o4R25QTDhKR0JCeFpz?=
 =?utf-8?B?NjByTTVsaUxUQmN5NEVIRmlpTXhzb1BXb0FJTnNuT01IOElqZWhVTzkxRjRP?=
 =?utf-8?B?YXArYWEvTm1BUm8vcUFhL2drZlhjbWRacHNrL3FtcU8xeUhOY2VJQ2YyUzVT?=
 =?utf-8?B?N0dLMnRBMlZrbmZibThiRWZJM0FLV25QUlE2TUtud3B4MGE1ZTk2bklFTmQ1?=
 =?utf-8?B?OWV0eHUvaEpTQkYwMW5pS1haTlNNY1hSVGpUNHhvOFd0V2NaNmxUQXZtaEx4?=
 =?utf-8?B?ZldwY0pyeDdJbk0wamxmTWwrdnR6SnY0V2c3T0UwckdCMEFQQVRZZlhXbFY3?=
 =?utf-8?B?NStxblF4WHoxdGRRWm9UZUNaMm1UdDhQMlZmOUNValBGNEZhbFVoR2NqMnN5?=
 =?utf-8?B?UDZNL2NBK1lDODU4RkRuNGVWQWUxZXdHUDdjYi82WkRPaGxFelVjWDg5VWtz?=
 =?utf-8?B?ck9MR2tXaERqd3dHZWR2dVZ4dzQwVGJ6ZHNBRmtWRm1PcWp1MDArN25EZ2x5?=
 =?utf-8?B?bi9hQ3NSSlgwaG5NZGZ5aDEwSGxEZ2hoWWl6Q3Vndlp1R3FBdkhDelQxRmdS?=
 =?utf-8?B?dXU4S3FNcmVtRGgzcjlUMjBCRmFNQmMvanhpT3FhR0FYTmxqZC9wRFFTMG9s?=
 =?utf-8?B?aEgyUzEySXpoU09LVVlMV21wUVk3UXlidmpWbDBndG5NOWRUaTdrcHpOeVJD?=
 =?utf-8?B?Y3Z5dFJ4NEtsSndib1NzaWpjY0xPTmZsbmpZVkFNQ3J2ZFpVc1dmekQyTHhp?=
 =?utf-8?B?cjJXWFgvM1hJbmd3RlNpVUloRkV0emZFa1Z6dDhpd0ZzT1g1WjdVOTA0blZ4?=
 =?utf-8?B?eER3UHFkTWdmUEJHWms4Z3VjRkFocHA0ci9qNDFrakkvbXhycHQ4RlFFOFhu?=
 =?utf-8?Q?qhzZlfWyjOQX2uzPzrii59A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05e2b724-e57e-47da-4786-08d9cfa2f27d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 16:55:01.1173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CgFw01LakpVE1AOzBfL0MfCGBySdYU7IQTDtCVwura/7e8ECOCR4QLCfK2Qk0YtV6/9j+FB8tyvx8+CJiyXYQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4606
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04.01.2022 17:50, Boris Ostrovsky wrote:
> 
> On 1/4/22 3:46 AM, Jan Beulich wrote:
>> The hypervisor has been supplying this information for a couple of major
>> releases. Make use of it. The need to set a flag in the capabilities
>> field also points out that the prior setting of that field from the
>> hypervisor interface's gbl_caps one was wrong, so that code gets deleted
>> (there's also no equivalent of this in native boot code).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/arch/x86/xen/vga.c
>> +++ b/arch/x86/xen/vga.c
>> @@ -63,13 +63,17 @@ void __init xen_init_vga(const struct do
>>   		}
>>   
>>   		if (size >= offsetof(struct dom0_vga_console_info,
>> -				     u.vesa_lfb.gbl_caps)
>> -		    + sizeof(info->u.vesa_lfb.gbl_caps))
>> -			screen_info->capabilities = info->u.vesa_lfb.gbl_caps;
>> -		if (size >= offsetof(struct dom0_vga_console_info,
>>   				     u.vesa_lfb.mode_attrs)
>>   		    + sizeof(info->u.vesa_lfb.mode_attrs))
> 
> 
> Do we still need this test? All 4.0+ hypervisors will have mode_attrs.

Perhaps this could also be dropped, but unlike the capabilities part
I'd view this as an unrelated change. Furthermore even a new hypervisor
would be free to omit the field, provided it also sets size low enough.

Jan