Date:   Tue, 4 Jan 2022 17:27:01 +0000
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Christian =?utf-8?B?TMO2aGxl?= <CLoehle@hyperstone.com>
Cc:     "jason.wessel@windriver.com" <jason.wessel@windriver.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dianders@chromium.org" <dianders@chromium.org>,
        "corbet@lwn.net" <corbet@lwn.net>
Subject: Re: [PATCH] Documentation: kgdb: Replace deprecated remotebaud
Message-ID: <20220104172701.7ychluvlcts4anab@maple.lan>
References: <13287b7914344c7995de27224cd2fa73@hyperstone.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <13287b7914344c7995de27224cd2fa73@hyperstone.com>
Precedence: bulk

On Tue, Jan 04, 2022 at 04:56:51PM +0000, Christian L?hle wrote:
> The gdb remotebaud to set baudrate has been replaced in favor of
> set serial baud many years ago.

I'd prefer to have a little more historical info in the patch header
so that anyone still running gdb-7.6 has a better shot at finding out
what is going on (some folks in the embedded world end up relying on
surprisingly old cross-toolsets).

In other words something more like:

  Using set remotebaud to set the baud rate was deprecated in
  gdb-7.7 and completely removed from the command parser in gdb-7.8
  (released in 2014). Adopt set serial baud instead.

Other than that the change looks good to me so with an improved
description containing the above versions and dates this can be:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Thanks

Daniel.


> 
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
>  Documentation/dev-tools/kgdb.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 43456244651a..7c90e111b364 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -557,7 +557,7 @@ Connecting with gdb to a serial port
>     Example (using a directly connected port)::
> 
>             % gdb ./vmlinux
> -           (gdb) set remotebaud 115200
> +           (gdb) set serial baud 115200
>             (gdb) target remote /dev/ttyS0
> 
> 
> --
> 2.34.1
> Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
> Managing Director: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782
>