Date:   Tue, 4 Jan 2022 11:56:16 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 13/40] x86/kernel: Make the bss.decrypted section
 shared in RMP table
Message-ID: <YdSKQKSTS83cRzGZ@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-14-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-14-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bZyoPmZmAFotav5XoGCHsrUEht4eIPIcbDv4UqTu+5jA3QB6v0FWIYmV48tp?=
 =?us-ascii?Q?l0c/TiPRs6UBz7kX4LKFCZpvrQn6eQpjf0b7Y8WUHV2HD6/pdAZp4G8L7uVt?=
 =?us-ascii?Q?U76AAtlL9Tk5ZvDMS36WMQ9pM7Kfss3+/tnSR5lF9Cj0GAS8SzVz3TSjiWpX?=
 =?us-ascii?Q?a4iabGKK2cOPCi6C18sxoNHvPAU6HqMLJMVgLGTEHHdv3J4djsaOTsADZqLC?=
 =?us-ascii?Q?7CUKoFmn5L56Tm6EllSk4jQjzNj5j/mAEZBNfM23aeO7VAnKajipy13BT2Af?=
 =?us-ascii?Q?XsArQvlRvSkFFGcydFJ70mBmOl08zfw7kJ7Kj2xnBuaYEOdb6Asn+YfPp3qm?=
 =?us-ascii?Q?Nwz0u2KS8/q5M37bx2PIx9QWR25p8mEwXsrHxCGR4gsCKidpYkCluLEPHlBM?=
 =?us-ascii?Q?KXcWwX4FENW42EymeW+Cdr0UCMsjinoJ9Fi7rSd11ZenlSWf6iYP5Vw/CxAk?=
 =?us-ascii?Q?sKMtjBW9ynU4MFnOwwDnxat+sMZguqJiL1QCdXlhyGHroQgw2EjLsaIVSH++?=
 =?us-ascii?Q?nNPlysXEIckxf1dhEJqxB/8TaWF9geGfOB7XzQ9ARxahlPkJy53LKC7JbOeF?=
 =?us-ascii?Q?60rf5QST3R8A/8r5Xn1ayhLiDoL8mBdvOhtsF5b6hHi9Nf8tJYZT01K6WdFh?=
 =?us-ascii?Q?oY1hwEqE6PMTVvRlJ0K89Aaw7vLH7RnVrX1sPAO9nV/g+S9fzxKfp1UA07+1?=
 =?us-ascii?Q?2fmxrWoDMOUxR3yVF0Xhe/hQwu7FFd+tbDZDY9zim340CnzJ9xr/es2P6KdC?=
 =?us-ascii?Q?Ag6pXOD88nWtQdeQw5frJ0G7JCoz2kS5GY/CK0hHvoZRIFD6H/UemHXdbQbX?=
 =?us-ascii?Q?F2mrcbs82N4dQZM8NEU+lhj46ZTLMXpkjBi12gTsSQdmfjVYaEZiwd2BonL2?=
 =?us-ascii?Q?frdRyKieEhcBTqW5Y2HX5ug0UrTklDB2Yo89KgITuD+IjHyTkf3bsJQI2IuC?=
 =?us-ascii?Q?VjHoO8X8PeIpIu2fqFnah28puavB23O3aCiMlih81T/cZQ9d3s4oPRwoGPvq?=
 =?us-ascii?Q?rW+nvrbY2mEvWkvtcrWVM+KiTGBXQc9CisOvtnl6BMk8vi6Bcdm1Nr+YDytr?=
 =?us-ascii?Q?uINmNXEJFgZHloKbFA7earnF34YID7H/A1QtXQWuN2Ts2sOTW8mGACKkyM3Q?=
 =?us-ascii?Q?vc1tyYXlxTW/vbxtF7uHaTGW5UvAoqDLlwbReuelQY6KfsYumt2FU4LAhPe5?=
 =?us-ascii?Q?YB7uLP1NK9gAJCMLKLUMJJ4ooV3qzFze8Ze/6UgvIKFD4P9cBGPFS/mPEfcU?=
 =?us-ascii?Q?jA1F7zlVCOJB4DXFICMbcOeDLq5j5PK2a845FhWg3E61CGRhAoa3LuefdFLj?=
 =?us-ascii?Q?6gEG6NgtzcewUp/VRDk38gc4kaAobFsG/JP/ZzjrF2gm0NbtiiTaEuzmA8VW?=
 =?us-ascii?Q?ZyvUIlxc5tAbbZRvSHIOeSsE+0kCy1ui9eITHBiRcI7LqyOFpGLnGUFH9cs2?=
 =?us-ascii?Q?iV6AAR1PvbuVCGtWwx/hU6yYlZ1sNAPBaCXrQpOpYoUqF8nRsIx7YVRTDJFM?=
 =?us-ascii?Q?yatrhyLnvn8gKw2BK/E4O/3FrqFDB5lM+VMFGg32ErbgE+f3PIKAsFtkuOn9?=
 =?us-ascii?Q?ARzCtLO79pt5BhGovLCX1OrLeBibipLeKdPwWnLklAc/QIlUw6CdM8cbSjpt?=
 =?us-ascii?Q?7f5u5sxY475bZQKFkS81xQfBF3hXhktgxjWDJY2aW5pa7KnYwxxFpyQjCHWz?=
 =?us-ascii?Q?cPZHjQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95e79e83-aeb6-4036-137d-08d9cfab86c6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 17:56:25.9809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FVWDPR2Hd6uypnzbt4LpczHLQ5v/1tKC/TzoaxA1bRoAwLjzbIFS+9lLXcMqOYRY1vgW9KQlQfK9YU8stfTmPfx7KJ6wRNLLMj8s/SS9avo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2462
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10217 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201040120
X-Proofpoint-GUID: CXsZh6t48v_8KWiEHYhlqld48H-CPeJn
X-Proofpoint-ORIG-GUID: CXsZh6t48v_8KWiEHYhlqld48H-CPeJn
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:43:05 -0600, Brijesh Singh wrote:
> The encryption attribute for the bss.decrypted region is cleared in the
> initial page table build. This is because the section contains the data
> that need to be shared between the guest and the hypervisor.
> 
> When SEV-SNP is active, just clearing the encryption attribute in the
> page table is not enough. The page state need to be updated in the RMP
> table.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
>  arch/x86/kernel/head64.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> index fa02402dcb9b..72c5082a3ba4 100644
> --- a/arch/x86/kernel/head64.c
> +++ b/arch/x86/kernel/head64.c
> @@ -143,7 +143,14 @@ static unsigned long sme_postprocess_startup(struct boot_params *bp, pmdval_t *p
>  	if (sme_get_me_mask()) {
>  		vaddr = (unsigned long)__start_bss_decrypted;
>  		vaddr_end = (unsigned long)__end_bss_decrypted;
> +
>  		for (; vaddr < vaddr_end; vaddr += PMD_SIZE) {
> +			/*
> +			 * When SEV-SNP is active then transition the page to shared in the RMP
> +			 * table so that it is consistent with the page table attribute change.
> +			 */
> +			early_snp_set_memory_shared(__pa(vaddr), __pa(vaddr), PTRS_PER_PMD);

Shouldn't the first argument be vaddr as below?

   			early_snp_set_memory_shared(vaddr, __pa(vaddr), PTRS_PER_PMD);

Venu