Date:   Tue, 4 Jan 2022 12:53:25 -0600
From:   Rob Herring <robh@kernel.org>
To:     David Heidelberg <david@ixit.cz>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Thierry Reding <treding@nvidia.com>,
        ~okias/devicetree@lists.sr.ht, linux-mmc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of
 dma-names
Message-ID: <YdSXpXI72sjrULVM@robh.at.kernel.org>
References: <20211224192545.74528-1-david@ixit.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211224192545.74528-1-david@ixit.cz>
Precedence: bulk

On Fri, Dec 24, 2021 at 08:25:45PM +0100, David Heidelberg wrote:
> We don't care in which order are "rx" and "tx" DMA names supplied.
> 

I do. Other than avoiding dts changes, why do we need undefined order 
here?

> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
> 

Drop the blank line.

> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index f0a44b2cfa79..a4f74bec68a3 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -70,9 +70,13 @@ properties:
>      maxItems: 2
>  
>    dma-names:
> -    items:
> -      - const: rx
> -      - const: tx
> +    oneOf:
> +      - items:
> +          - const: tx
> +          - const: rx
> +      - items:
> +          - const: rx
> +          - const: tx

For future reference, the concise way to express this is:

maxItems: 2
items:
  enum: [ rx, tx ]

>  
>    power-domains: true
>  
> -- 
> 2.34.1
> 
>