MIME-Version: 1.0
References: <4C0186FE-729D-4F77-947D-11933BA38818@gmail.com>
 <CAM9d7ciroZswudPXAAs9Zo3_veFMugJJZ4XZWhGSKHdFPcDOjQ@mail.gmail.com> <64E36F38-E037-4561-8E0C-B288674A5BD9@gmail.com>
In-Reply-To: <64E36F38-E037-4561-8E0C-B288674A5BD9@gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 4 Jan 2022 11:33:38 -0800
Message-ID: <CAM9d7cgzpyp03y3w009upnftK=24r8NtQFZB0t23pnc1PwyJug@mail.gmail.com>
Subject: Re: Lock problems in linux/tools/perf/util/dso.c
To:     Ryan Cai <ycaibb@gmail.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 29, 2021 at 6:42 PM Ryan Cai <ycaibb@gmail.com> wrote:
>
> Hi, Namhyung,
>
> 1. Indeed, I got wrong here.
> 2. Yes, the branch should be if (pthread_mutex_lock(&dso__data_open_lock))
> instead of if (pthread_mutex_lock(&dso__data_open_lock) < 0).
>
> Could I send a patch?

Sure!

Thanks,
Namhyung