Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39210C433FE for ; Tue, 4 Jan 2022 20:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232970AbiADUfA (ORCPT ); Tue, 4 Jan 2022 15:35:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbiADUe7 (ORCPT ); Tue, 4 Jan 2022 15:34:59 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 338AAC061761 for ; Tue, 4 Jan 2022 12:34:59 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id x15so27837272plg.1 for ; Tue, 04 Jan 2022 12:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OMgPsxT7s5PUJzgh0jesH43SAy7zYp7IDqaflLd8kOc=; b=BnDklxMF7GBWTXml42AjnB8XOURccxORWmexAsnJvQUg+zPmhAke+angtUP+2jxFp5 8YuDGsxl76thTZaW0BtpYLlfafDST7n2NfpnIhBs6q9ZH+guJqzDHCK0uuDvrlG2/nEZ Em/cMx0FJ+AmI3oeRyFDN/JKVwYfc3rgodds2IwwfSXBaD+4o+gmdx3w/xee2pPrNZuO v67koTt5zCsm2lO1T3pHwa51JCNtiPLfnqr478W5NnIK9QdzD7AgxSxGfFVzZ7Us9QqP mi2ifaursDFUk4PZduCJHC4SCrmaZM45O5/b6TwXc2Hav2yfvqZmy/HaWeCVrOz4ThGf bhfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OMgPsxT7s5PUJzgh0jesH43SAy7zYp7IDqaflLd8kOc=; b=h7tXo6UnXjUfSE+v+9P3kUAHkc6vovfdqb8QSqDlktLfv+VTw9w/BAW4z4wJ/gF9s0 HbPwloFcTOF6hBTF41rOX73gaCJrvtym7eysDbw/DDX+ZneleZ23/sMvejfD8agAHLLn b4NQu6mkKbWS78+V16Y+c5HUCWymCmFW6AEwjpYeMCBRawvwyPKE3N0cv/YdFzYFM+TB PI+urxFc00/vsQ8+p0JdBxxlg1pvRuvjReoLn59fFS6ohhfzc3uYvniFI2zVIgB9obRc UBexB0LusMJPSYB39A8ua0hOb2KmQKklwOxChobqY+ette0h6IaMwZZnKyeXe5Ln2CRn 5ymA== X-Gm-Message-State: AOAM530TUTK5p/h4uXHfE4YwGH2wiTiLVWvlj+jX0K7yvfiXPbiHmaJt 14FEnh107eXrV1TipSEOhKOhww== X-Google-Smtp-Source: ABdhPJzDELlvn+sVviC6DXPdOsKXoAEYSXl3/DER8ndMXGraW8vZtyulFLLmGVGlcwUtk4Ty0nd5hQ== X-Received: by 2002:a17:903:2307:b0:149:1bb6:fc28 with SMTP id d7-20020a170903230700b001491bb6fc28mr50288398plh.84.1641328498636; Tue, 04 Jan 2022 12:34:58 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id y3sm187543pju.37.2022.01.04.12.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 12:34:58 -0800 (PST) Date: Tue, 4 Jan 2022 20:34:54 +0000 From: Sean Christopherson To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Lai Jiangshan , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [RFC PATCH 2/6] KVM: X86: Walk shadow page starting with shadow_root_level Message-ID: References: <20211210092508.7185-1-jiangshanlai@gmail.com> <20211210092508.7185-3-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211210092508.7185-3-jiangshanlai@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 10, 2021, Lai Jiangshan wrote: > From: Lai Jiangshan > > Walking from the root page of the shadow page table should start with > the level of the shadow page table: shadow_root_level. > > Also change a small defect in audit_mappings(), it is believed > that the current walking level is more valuable to print. > > Signed-off-by: Lai Jiangshan > --- > arch/x86/kvm/mmu/mmu_audit.c | 5 ++--- I vote we remove mmu_audit.c. It has bitrotted horribly, and none of the current set of KVM developers even knows how to use it effectively.