Message-ID: <a4fbf2ec33e7bbf81ea8c4750a5064ab67b94428.camel@redhat.com>
Subject: Re: [RFC PATCH 2/6] KVM: X86: Walk shadow page starting with
 shadow_root_level
From:   Maxim Levitsky <mlevitsk@redhat.com>
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Lai Jiangshan <laijs@linux.alibaba.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>
Date:   Tue, 04 Jan 2022 22:43:14 +0200
In-Reply-To: <c16e310f-8ae5-9c29-04c7-7355834ce803@redhat.com>
References: <20211210092508.7185-1-jiangshanlai@gmail.com>
         <20211210092508.7185-3-jiangshanlai@gmail.com>
         <YdSvbsb5wt/WURtw@google.com>
         <c16e310f-8ae5-9c29-04c7-7355834ce803@redhat.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-01-04 at 21:37 +0100, Paolo Bonzini wrote:
> On 1/4/22 21:34, Sean Christopherson wrote:
> > On Fri, Dec 10, 2021, Lai Jiangshan wrote:
> > > From: Lai Jiangshan<laijs@linux.alibaba.com>
> > > 
> > > Walking from the root page of the shadow page table should start with
> > > the level of the shadow page table: shadow_root_level.
> > > 
> > > Also change a small defect in audit_mappings(), it is believed
> > > that the current walking level is more valuable to print.
> > > 
> > > Signed-off-by: Lai Jiangshan<laijs@linux.alibaba.com>
> > > ---
> > >   arch/x86/kvm/mmu/mmu_audit.c | 5 ++---
> > 
> > I vote we remove mmu_audit.c.  It has bitrotted horribly, and none of the
> > current set of KVM developers even knows how to use it effectively.
> 
> No complaints.

I played with it once, its not that bad IMHO.

Best regards,
	Maxim Levitsky

> 
> Paolo
>