Message-ID: <fd7f6a115ece824c75f5b8fd02f1fc84cefca176.camel@mailoo.org>
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sc7280: Add nodes for va tx
 and rx macros and external codecs
From:   Vincent Knecht <vincent.knecht@mailoo.org>
To:     Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
        agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, rohitkr@codeaurora.org,
        srinivas.kandagatla@linaro.org, dianders@chromium.org,
        swboyd@chromium.org, judyhsiao@chromium.org
Cc:     Venkata Prasad Potturu <quic_potturu@quicinc.com>
Date:   Tue, 04 Jan 2022 23:04:23 +0100
In-Reply-To: <1641208380-15510-2-git-send-email-quic_srivasam@quicinc.com>
References: <1641208380-15510-1-git-send-email-quic_srivasam@quicinc.com>
         <1641208380-15510-2-git-send-email-quic_srivasam@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.2 (3.42.2-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le lundi 03 janvier 2022 =C3=A0 16:42 +0530, Srinivasa Rao Mandadapu a =C3=
=A9crit=C2=A0:
> SC7280 has VA, TX and RX macros with SoundWire Controllers to attach with
> codecs like WCD938x, max98360a using soundwire masters and i2s bus.
> Add these nodes for sc7280 based platforms audio use case.
> Add tlmm gpio property in wcd938x node for switching CTIA/OMTP Headset.
>=20
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> =C2=A0arch/arm64/boot/dts/qcom/sc7280-crd.dts=C2=A0 |=C2=A0=C2=A0 4 ++
> =C2=A0arch/arm64/boot/dts/qcom/sc7280-idp.dtsi |=C2=A0 52 ++++++++++++++
> =C2=A0arch/arm64/boot/dts/qcom/sc7280.dtsi=C2=A0=C2=A0=C2=A0=C2=A0 | 113 =
+++++++++++++++++++++++++++++++
> =C2=A03 files changed, 169 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dt=
s/qcom/sc7280-crd.dts
> index cd2755c..035cca9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -72,6 +72,10 @@ ap_ts_pen_1v8: &i2c13 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pins =3D "gpio51";
> =C2=A0};
> =C2=A0
> +&wcd938x {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0qcom,us-euro-gpios =3D <&tlmm =
81 0>;
> +};
> +

Maybe using a defined value is possible, rather than an obscure zero ?
GPIO_ACTIVE_HIGH ?