MIME-Version: 1.0
References: <20220104162947.1320936-1-gregkh@linuxfoundation.org>
In-Reply-To: <20220104162947.1320936-1-gregkh@linuxfoundation.org>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Tue, 4 Jan 2022 23:12:52 +0100
Message-ID: <CAMGffEmc=2m6xs_QOCRDbFgU5=3EpYOJqce-DRi=k=Yr4YbJYw@mail.gmail.com>
Subject: Re: [PATCH] block/rnbd-clt-sysfs: use default_groups in kobj_type
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org,
        "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
        Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 4, 2022 at 5:29 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the rnbd controller sysfs code to use default_groups field
> which has been the preferred way since aa30f47cf666 ("kobject: Add
> support for default attribute groups to kobj_type") so that we can soon
> get rid of the obsolete default_attrs field.
>
> Cc: "Md. Haris Iqbal" <haris.iqbal@ionos.com>
> Cc: Jack Wang <jinpu.wang@ionos.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Thanks!
> ---
>  drivers/block/rnbd/rnbd-clt-sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c
> index 44e45af00e83..2be5d87a3ca6 100644
> --- a/drivers/block/rnbd/rnbd-clt-sysfs.c
> +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c
> @@ -452,6 +452,7 @@ static struct attribute *rnbd_dev_attrs[] = {
>         &rnbd_clt_nr_poll_queues.attr,
>         NULL,
>  };
> +ATTRIBUTE_GROUPS(rnbd_dev);
>
>  void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev)
>  {
> @@ -474,7 +475,7 @@ void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev)
>
>  static struct kobj_type rnbd_dev_ktype = {
>         .sysfs_ops      = &kobj_sysfs_ops,
> -       .default_attrs  = rnbd_dev_attrs,
> +       .default_groups = rnbd_dev_groups,
>  };
>
>  static int rnbd_clt_add_dev_kobj(struct rnbd_clt_dev *dev)
> --
> 2.34.1
>