Date:   Tue, 4 Jan 2022 16:59:39 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 16/40] KVM: SVM: Define sev_features and vmpl field in
 the VMSA
Message-ID: <YdTRW6MeJtUmd8zi@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-17-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-17-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NT7rYfFWWU+VDNLMZFbymviDBxWDQmfOhNo2oAm79xMQH/iXFNmVqjwNI4vi?=
 =?us-ascii?Q?aVP2IKKTSgXv32UZkvCeazmjkUsk2lDnptgp8wAIpF89asbDhkMq3fqyy2hE?=
 =?us-ascii?Q?OCz9EwenX4IxNLHrl0OUG1w19T42T3ganhLcTV1KkgqtsiUmB8whpXs1xls7?=
 =?us-ascii?Q?wdeSkPuhqm0emOIFOMI5T9qZlQhhU6PExFVA11PZBeo+98+PSV6GNGfZQ+BT?=
 =?us-ascii?Q?Hkp/VVea6Fy1Hurh2yr/dqc+a/e/VJ3mtIKH4PqokkE55mTCHbQ5a1uXeXPR?=
 =?us-ascii?Q?xcEIkr2Jmo9BFrmP4676jWBkUrGlVddaJPzpdDMDEJ7vSnIBh6CzeNlb87Ll?=
 =?us-ascii?Q?S2ipToyEyU1m0Pdr5Smrx4F+s3FGLWr8QGe/L9ZNDnwa6SEgi0bvfl5o0zaj?=
 =?us-ascii?Q?vqeJ7cV0dGmS/MckXtwSxvoWGcuy/gZKrloXbN58ALMtJB8xgrCqTQIM6Eb6?=
 =?us-ascii?Q?SMkNnUsziTPZ5M6+e/Z7YaLIaAAXc78vZjy97GEBcJmNFXRfs5RLhTw45LdM?=
 =?us-ascii?Q?Q9kAWvrtdnAUwj8x42ePlv23rGroec1qBMDZnBVrbZVVaO9UBCt6eNn3Ia1R?=
 =?us-ascii?Q?fJMpQGOhjWTyE+jlXiCCM6oqtbW9yj88IZAVz6vP8/nChvMl62nrIhSqlpI0?=
 =?us-ascii?Q?NBXmpCHmn8iHaE4YDZ4kMlNxWVhIiDBhe/hJayu2M6f/jVzsWc1+GZ75JWhq?=
 =?us-ascii?Q?XW9Gzsdht8LH144JYBYGrTyyHpx9tTLVwbft0hrtpp/Cfa52HP3Syuy7ArbJ?=
 =?us-ascii?Q?Gdi90YSg4OQ0bH5eOj+JjQtjHKW9OWjrHd9X3GKq86nFAL27LiHZ0DDHCrT9?=
 =?us-ascii?Q?2J9V8o3ill5CuJTbzAh4kPZeeDSgyY4uTpgF86aUgBoP9HDCJiF+5rJ8Ujxg?=
 =?us-ascii?Q?ZRy/XFXBh+ftTf3ty0k/mkzoghA/Y1KzBSID9wQDwfkUApAbwGnO/P3kB8Ib?=
 =?us-ascii?Q?5IhpptLdtFnUpeP21X3SsQOu7HnrcwAN4FzHQhTjCA1fFHZin9BcczhK0Kw/?=
 =?us-ascii?Q?ZMlcuEVQ+2SNXGz9oSVOO1nzYAwHI866pA1n8k2fvSmikPu4WtBsKOOFF4Ib?=
 =?us-ascii?Q?ef4kJb28n7FwC/SnY6822a3g2DhaYngr9JVPt20vbcQPW2GtPsndqmTULrsa?=
 =?us-ascii?Q?JivKUc043FOIYfvb9wCIjYTImF9FRCzjQ6kbgNIyqxctFCyHry0mOtMVZenI?=
 =?us-ascii?Q?QLQDK0kysCzEwINXe+Y+KULHFQvk3viizVsWmj2Q+viM5xD5kOsvy8PxTzxn?=
 =?us-ascii?Q?+DIZAXfJT1i/seupHniPp2TzzFRtXS4SIXdjIETx4rtGB0lsxM7cvtGbwvwp?=
 =?us-ascii?Q?CtUGTvup20gggusYUqrPMZ9cie0OztE84u/S55o21mB8Ea4nB6cftudUexCX?=
 =?us-ascii?Q?eTR1Q4rmGDS8tjtdRDn8XLkbm5VdtlJL2r4F7H0Z2go/ycYwWStD5/rySV1I?=
 =?us-ascii?Q?+LNkuozqfXgW/J6OS5uqPFpifOLz53sMVLibemK8wApWqrkwuugDM2OcxUiP?=
 =?us-ascii?Q?rzEtvfd6GdraoYf1C0oJWh4GEimqZw4ZmaDNJJYuWazHSOlOd9A5bu2K1IyJ?=
 =?us-ascii?Q?raNfbzERb2a2Z/ElSu1BMzPRrd8Dys46OCnaon7qRp11rWPFWN3d3m/sAvh1?=
 =?us-ascii?Q?r2OU3yo6LZsxBYErtf3o5IW3ZLc+XspYKH5NHP9wOCnv1D76IXgu4jskzRbA?=
 =?us-ascii?Q?TjOMOA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a72d002e-9789-4513-ab22-08d9cfd5e66e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 22:59:45.2291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8oxoYGom4dhPu9RHdnujC0pm2YtDv/fzLUBLVf9GX5cuJE2Kh7VJHTT27/fUCnqVdBpmZZri+EFRoaJk8W2JUKHvkMs7+VmNRixOjmPefJk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4683
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10217 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201040147
X-Proofpoint-ORIG-GUID: TXIzLZ4PtEcBqguPn2Q5L5mfgyWG-jKb
X-Proofpoint-GUID: TXIzLZ4PtEcBqguPn2Q5L5mfgyWG-jKb
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:43:08 -0600, Brijesh Singh wrote:
> The hypervisor uses the sev_features field (offset 3B0h) in the Save State
> Area to control the SEV-SNP guest features such as SNPActive, vTOM,
> ReflectVC etc. An SEV-SNP guest can read the SEV_FEATURES fields through
> the SEV_STATUS MSR.
> 
> While at it, update the dump_vmcb() to log the VMPL level.
> 
> See APM2 Table 15-34 and B-4 for more details.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>

> ---
>  arch/x86/include/asm/svm.h | 6 ++++--
>  arch/x86/kvm/svm/svm.c     | 4 ++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
> index d3277486a6c0..c3fad5172584 100644
> --- a/arch/x86/include/asm/svm.h
> +++ b/arch/x86/include/asm/svm.h
> @@ -238,7 +238,8 @@ struct vmcb_save_area {
>  	struct vmcb_seg ldtr;
>  	struct vmcb_seg idtr;
>  	struct vmcb_seg tr;
> -	u8 reserved_1[43];
> +	u8 reserved_1[42];
> +	u8 vmpl;
>  	u8 cpl;
>  	u8 reserved_2[4];
>  	u64 efer;
> @@ -303,7 +304,8 @@ struct vmcb_save_area {
>  	u64 sw_exit_info_1;
>  	u64 sw_exit_info_2;
>  	u64 sw_scratch;
> -	u8 reserved_11[56];
> +	u64 sev_features;
> +	u8 reserved_11[48];
>  	u64 xcr0;
>  	u8 valid_bitmap[16];
>  	u64 x87_state_gpa;
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 65707bee208d..d3a6356fa1af 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3290,8 +3290,8 @@ static void dump_vmcb(struct kvm_vcpu *vcpu)
>  	       "tr:",
>  	       save01->tr.selector, save01->tr.attrib,
>  	       save01->tr.limit, save01->tr.base);
> -	pr_err("cpl:            %d                efer:         %016llx\n",
> -		save->cpl, save->efer);
> +	pr_err("vmpl: %d   cpl:  %d               efer:          %016llx\n",
                                                       ^
Extra space?

> +	       save->vmpl, save->cpl, save->efer);
>  	pr_err("%-15s %016llx %-13s %016llx\n",
>  	       "cr0:", save->cr0, "cr2:", save->cr2);
>  	pr_err("%-15s %016llx %-13s %016llx\n",
> -- 
> 2.25.1
>