Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Wed, 5 Jan 2022 01:11:03 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "Kirill A. Shutemov" <kirill@shutemov.name>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Ard Biesheuvel <ardb@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] headers/uninline: Uninline single-use function:
 kobject_has_children()
Message-ID: <YdTiF5dVeizYtIDS@gmail.com>
References: <YdIfz+LMewetSaEB@gmail.com>
 <20220103135400.4p5ezn3ntgpefuan@box.shutemov.name>
 <YdQnfyD0JzkGIzEN@gmail.com>
 <YdRM7I9E2WGU4GRg@kroah.com>
 <YdRRl+jeAm/xfU8D@gmail.com>
 <YdRjRWHgvnqVe8UZ@kroah.com>
 <YdRkZqGuKCZcRbov@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YdRkZqGuKCZcRbov@kroah.com>
Precedence: bulk


* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Tue, Jan 04, 2022 at 04:09:57PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 04, 2022 at 02:54:31PM +0100, Ingo Molnar wrote:
> > > 
> > > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > 
> > > > On Tue, Jan 04, 2022 at 11:54:55AM +0100, Ingo Molnar wrote:
> > > > > There's one happy exception though, all the uninlining patches that 
> > > > > uninline a single-call function are probably fine as-is:
> > > > 
> > > > <snip>
> > > > 
> > > > >  3443e75fd1f8 headers/uninline: Uninline single-use function: kobject_has_children()
> > > > 
> > > > Let me go take this right now, no need for this to wait, it should be
> > > > out of kobject.h as you rightfully show there is only one user.
> > > 
> > > Sure - here you go!
> > 
> > I just picked it out of your git tree already :)
> > 
> > Along those lines, any objection to me taking at least one other one?
> > 3f8757078d27 ("headers/prep: usb: gadget: Fix namespace collision") and

Ack.

> > 6fb993fa3832 ("headers/deps: USB: Optimize <linux/usb/ch9.h>

Ack.

> > dependencies, remove <linux/device.h>") look like I can take now into my
> > USB tree with no problems.
> 
> Also these look good to go now:
> 	bae9ddd98195 ("headers/prep: Fix non-standard header section: drivers/usb/cdns3/core.h")

Ack.

> 	c027175b37e5 ("headers/prep: Fix non-standard header section: drivers/usb/host/ohci-tmio.c")

Ack.

Note that these latter two patches just simplified the task of my 
(simplistic) tooling, which is basically a shell script that inserts
header dependencies to the head of .c and .h files, right in front of
the first #include line it encounters.

These two patches do have some marginal clean-up value too, so I'm not 
opposed to merging them - just wanted to declare their true role. :-)

Thanks,

	Ingo