Date:   Wed, 5 Jan 2022 03:31:08 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Borislav Petkov <bp@alien8.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>, tglx@linutronix.de,
        mingo@redhat.com, luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/26] x86/tdx: Make pages shared in ioremap()
Message-ID: <20220105003108.mr7zyd5oyaaxmnmv@box.shutemov.name>
References: <YcTlhp1PUfrMOelI@zn.tnic>
 <20211224110300.7zj3nc5nbbv7jobp@black.fi.intel.com>
 <33914dc1-37e8-f0bb-6468-71c3b5f4169d@amd.com>
 <20220103141705.6hqflhwykqmtfim6@black.fi.intel.com>
 <YdMIWAT42el4D6wJ@zn.tnic>
 <20220103151516.pfcz2pap5l7r2rzv@box.shutemov.name>
 <b4b54116-1cd7-468a-0889-d497268cbfb2@intel.com>
 <20220103181059.ui5eloufw5gsojcb@box.shutemov.name>
 <20220104191424.oly2gqm4ltzj5wo3@box.shutemov.name>
 <0e0c38e2-67ad-1f51-c44b-d3c3d505e40a@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0e0c38e2-67ad-1f51-c44b-d3c3d505e40a@intel.com>
Precedence: bulk

On Tue, Jan 04, 2022 at 12:36:06PM -0800, Dave Hansen wrote:
> On 1/4/22 11:14 AM, Kirill A. Shutemov wrote:
> > I see two possible options (I hate both): leave it defined in per-arch
> > <asm/pgtable.h> or move it to <linux/mm.h> next to user in
> > io_remap_pfn_range().
> 
> Could we do an asm-generic/pgprot.h that was basically just:
> 
> 	typedef struct { unsigned long pgprot; } pgprot_t;
> 
> That would cover probably 80% of the of the architectures.  The rest of
> them could define an actual asm/pgprot.h.

A file per typedef looks like an overkill.

Maybe <asm-generic/types.h> that included from <asm/types.h> would be
easier to justify. Some archs already have <asm/types.h>

Although, it is not as simple as your patches. See below.

> 
> It doesn't seem to be *that* much work, although it is a bit of a shame
> that pgtable-types.h doesn't fix this already.  I've attached something
> that compiles on s390 (representing a random non-x86 architecture) and x86.


> diff -puN arch/sparc/include/asm/page_32.h~pgprot-generic arch/sparc/include/asm/page_32.h
> --- a/arch/sparc/include/asm/page_32.h~pgprot-generic	2022-01-04 12:00:31.651180536 -0800
> +++ b/arch/sparc/include/asm/page_32.h	2022-01-04 12:00:31.659180446 -0800
> @@ -10,6 +10,7 @@
>  #define _SPARC_PAGE_H
>  
>  #include <linux/const.h>
> +#include <asm-generic/pgprot.h>
>  
>  #define PAGE_SHIFT   12
>  #define PAGE_SIZE    (_AC(1, UL) << PAGE_SHIFT)
> @@ -57,7 +58,6 @@ typedef struct { unsigned long iopte; }
>  typedef struct { unsigned long pmd; } pmd_t;
>  typedef struct { unsigned long pgd; } pgd_t;
>  typedef struct { unsigned long ctxd; } ctxd_t;
> -typedef struct { unsigned long pgprot; } pgprot_t;
>  typedef struct { unsigned long iopgprot; } iopgprot_t;
>  
>  #define pte_val(x)	((x).pte)
> @@ -85,7 +85,6 @@ typedef unsigned long iopte_t;
>  typedef unsigned long pmd_t;
>  typedef unsigned long pgd_t;
>  typedef unsigned long ctxd_t;
> -typedef unsigned long pgprot_t;
>  typedef unsigned long iopgprot_t;
>  
>  #define pte_val(x)	(x)

Any arch that use STRICT_MM_TYPECHECKS hacks will get broken if compiled
without the define (as sparc by default).

It's fixable with more crunch (and more build bugs). I think we can use
approach from posix_types.h where asm-generic version defines the type if
it was not defined by the arch code.

Is it the way to go we want?

-- 
 Kirill A. Shutemov