Date:   Tue, 4 Jan 2022 19:22:33 -0600
From:   Rob Herring <robh@kernel.org>
To:     frowand.list@gmail.com
Cc:     linux-kernel@vger.kernel.org, erhard_f@mailbox.org,
        Rob Herring <robh+dt@kernel.org>, yinxiujiang@kylinos.cn,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] of: unittest: re-implement overlay tracking
Message-ID: <YdTy2TmEzR+eLHVx@robh.at.kernel.org>
References: <20220101033329.1277779-1-frowand.list@gmail.com>
 <20220101033329.1277779-3-frowand.list@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220101033329.1277779-3-frowand.list@gmail.com>
Precedence: bulk

On Fri, 31 Dec 2021 21:33:29 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> Some overlays are tracked when they are applied.  The tracked overlays
> are later removed after the overlay tests are completed.  The old
> implementation makes assumptions about the expected values for
> overlay changeset id created by the overlay apply which result
> in fragile code.  The new code removes the assumptions.
> 
> A symptom that exposes a problem with the tracking code is a
> warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36",
> Kernel Version: 5.15-rc7, PPC-64, Talos II.  This results from variable
> "id" value of -1 in the final line of of_unittest_untrack_overlay().
> 
> Reported-by: erhard_f@mailbox.org
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
>  drivers/of/unittest.c | 110 +++++++++++++++++++-----------------------
>  1 file changed, 49 insertions(+), 61 deletions(-)
> 

Applied, thanks!