Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates
 194.138.21.71 as permitted sender) receiver=protection.outlook.com;
 client-ip=194.138.21.71; helo=hybrid.siemens.com;
Date:   Wed, 5 Jan 2022 08:32:38 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Aaron Ma <aaron.ma@canonical.com>
CC:     <kuba@kernel.org>, <linux-usb@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <hayeswang@realtek.com>, <tiwai@suse.de>
Subject: Re: [PATCH] net: usb: r8152: Check used MAC passthrough address
Message-ID: <20220105083238.4278d331@md1za8fc.ad001.siemens.net>
In-Reply-To: <20220105082355.79d44349@md1za8fc.ad001.siemens.net>
References: <20220105061747.7104-1-aaron.ma@canonical.com>
        <20220105082355.79d44349@md1za8fc.ad001.siemens.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 07:32:40.7949
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 280548fe-ee68-488b-32a1-08d9d01d8e3c
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.71];Helo=[hybrid.siemens.com]
X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT006.eop-EUR01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB4348
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 5 Jan 2022 08:23:55 +0100
schrieb Henning Schild <henning.schild@siemens.com>:

> Hi Aaron,
> 
> if this or something similar goes in, please add another patch to
> remove the left-over defines.
> 
> Am Wed,  5 Jan 2022 14:17:47 +0800
> schrieb Aaron Ma <aaron.ma@canonical.com>:
> 
> > When plugin multiple r8152 ethernet dongles to Lenovo Docks
> > or USB hub, MAC passthrough address from BIOS should be
> > checked if it had been used to avoid using on other dongles.
> > 
> > Currently builtin r8152 on Dock still can't be identified.
> > First detected r8152 will use the MAC passthrough address.
> > 
> > Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> > ---
> >  drivers/net/usb/r8152.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> > index f9877a3e83ac..77f11b3f847b 100644
> > --- a/drivers/net/usb/r8152.c
> > +++ b/drivers/net/usb/r8152.c
> > @@ -1605,6 +1605,7 @@ static int
> > vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr
> > *sa) char *mac_obj_name; acpi_object_type mac_obj_type;
> >  	int mac_strlen;
> > +	struct net_device *ndev;
> >  
> >  	if (tp->lenovo_macpassthru) {
> >  		mac_obj_name = "\\MACA";
> > @@ -1662,6 +1663,15 @@ static int
> > vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
> > ret = -EINVAL; goto amacout;
> >  	}
> > +	rcu_read_lock();
> > +	for_each_netdev_rcu(&init_net, ndev) {
> > +		if (strncmp(buf, ndev->dev_addr, 6) == 0) {
> > +			rcu_read_unlock();
> > +			goto amacout;  
> 
> Since the original PCI netdev will always be there, that would disable
> inheritance would it not?
> I guess a strncmp(MODULE_NAME, info->driver, strlen(MODULE_NAME)) is
> needed as well.
> 
> Maybe leave here with
> netif_info()
> 
> And move the whole block up, we can skip the whole ACPI story if we
> find the MAC busy.

That is wrong, need to know that MAC so can not move up too much. But
maybe above the is_valid_ether_addr

Henning

> > +		}
> > +	}
> > +	rcu_read_unlock();  
> 
> Not sure if this function is guaranteed to only run once at a time,
> otherwise i think that is a race. Multiple instances could make it to
> this very point at the same time.
> 
> Henning
> 
> >  	memcpy(sa->sa_data, buf, 6);
> >  	netif_info(tp, probe, tp->netdev,
> >  		   "Using pass-thru MAC addr %pM\n", sa->sa_data);
> >  
>