Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965242AbXA3HNO (ORCPT ); Tue, 30 Jan 2007 02:13:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965253AbXA3HNO (ORCPT ); Tue, 30 Jan 2007 02:13:14 -0500 Received: from nommos.sslcatacombnetworking.com ([67.18.224.114]:60271 "EHLO nommos.sslcatacombnetworking.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965242AbXA3HNN (ORCPT ); Tue, 30 Jan 2007 02:13:13 -0500 In-Reply-To: <8DAAF0FE-E76A-4C1F-94B7-36BE839EA6BE@kernel.crashing.org> References: <20070130055556.GA20699@in.ibm.com> <8DAAF0FE-E76A-4C1F-94B7-36BE839EA6BE@kernel.crashing.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <112DEBE1-0765-40DC-B8FD-75DE7336312A@kernel.crashing.org> Cc: ananth@in.ibm.com, Linux Kernel list , prasanna@in.ibm.com, anil.s.keshavamurthy@intel.com, "David S. Miller" , Paul Mackerras , masami.hiramatsu.pt@hitachi.com Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [PATCH] kprobes: Fix compiler warning Date: Tue, 30 Jan 2007 01:12:17 -0600 To: Andrew Morton X-Mailer: Apple Mail (2.752.2) X-PopBeforeSMTPSenders: kumar-chaos@kgala.com,kumar-statements@kgala.com,kumar@kgala.com X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - nommos.sslcatacombnetworking.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.crashing.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 42 On Jan 30, 2007, at 1:05 AM, Kumar Gala wrote: > > On Jan 29, 2007, at 11:55 PM, Ananth N Mavinakayanahalli wrote: > >> On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote: >>> On ppc the compiler gripes about: >>> >>> kernel/kprobes.c: In function 'collect_garbage_slots': >>> kernel/kprobes.c:215: warning: comparison is always false due to >>> limited >>> range of data type >>> >>> The compiler ends up optimizing away the test since char's are >>> unsigned on >>> ppc. >> >> Kumar, >> >> Masami fixed this last week: >> >> http://marc.theaimsgroup.com/?l=linux-kernel&m=116968723823366&w=2 >> >> Patch currently in -mm. >> >> Thanks, >> Ananth > > Cool, Masami's patch looks far more complete. Andrew, What are your thoughts on forward Masami patch to Linus for 2.6.20 since it fixes a real bug on PPC? - k - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/