Date:   Wed, 05 Jan 2022 09:26:16 +0100
Message-ID: <s5ha6gak2qf.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Baole Fang <fbl718@163.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Hui Wang <hui.wang@canonical.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
        Elia Devito <eliadevito@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Legion Y9000X 2020
In-Reply-To: <20220105034103.12484-1-fbl718@163.com>
References: <20220105034103.12484-1-fbl718@163.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 05 Jan 2022 04:41:01 +0100,
Baole Fang wrote:
> 
> commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream.

I couldn't find this commit.  Is this a bogus information?

> Legion Y9000X 2020 has a speaker, but the speaker doesn't work.
> This can be fixed by applying alc285_fixup_ideapad_s740_coef
>  to fix the speaker's coefficients.
> Besides, to support the transition between the speaker and the headphone,
> alc287_fixup_legion_15imhg05_speakers needs to be run.
> 
> Signed-off-by: Baole Fang <fbl718@163.com>

The code change itself looks fine, so I'd apply it if the line above
can be omitted.


thanks,

Takashi