From:   "S.J. Wang" <shengjiu.wang@nxp.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "timur@kernel.org" <timur@kernel.org>,
        "nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>,
        "Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on
 i.MX8MQ
Thread-Topic: [PATCH 1/3] ASoC: imx-card: Need special setting for ak4497 on
 i.MX8MQ
Thread-Index: AdgCEhZ7Lb6RtTFBSJ+4JF9NIvhERw==
Date:   Wed, 5 Jan 2022 09:02:40 +0000
Message-ID: <PAXPR04MB9089C99640D09D6CC22AC0DFE34B9@PAXPR04MB9089.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yfl1q6Gy8mD9rMr4Xtmc1TTwBGit4VYPbJRPJGgMKWn220ft5wvzxEDF9EK5?=
 =?us-ascii?Q?8heNhe+LMlc970x95OLwILHjMciO0Qtrd0gT4ubBvs1/hRHPNd1scUCmZ1iC?=
 =?us-ascii?Q?hP4iy3w+fVv7lx3PjERwmay2e+8JbufjV0StlmgWFBIJxPBge6y7Jw+4nT9T?=
 =?us-ascii?Q?TbbMMUBtuukfj1jAG0ek0FmZwL7ndrGzDn/JVwUYK4FcARidO9cPdxvqUA+R?=
 =?us-ascii?Q?q9iAm3PBWX24mc3MDF6QjDIWS4GokJFkG7T3B6mHoWji6fOMjTioyZklDXeB?=
 =?us-ascii?Q?GHW2A/3ZMiqcdb/CPZEriIBGEEKM3NSplgeOTUPMTqKNUESbDL1l3DUNdHiS?=
 =?us-ascii?Q?+OrHbXmy1I/OAUTz4m4VSa8dQr+/K5YDaoeIEz72N8OWXOAMKpifn2Lqz32g?=
 =?us-ascii?Q?u7c+5vMbKqlCMGINpCMV8rXmmxaBT8vaM7JP3vF8u9ZDCZyoGtgT8MJ6a0Qc?=
 =?us-ascii?Q?PHTPT7697d8CPMjJk7XqerfenKXM0oHcuXsOeGPgh3oPVRWhwY5ae/jwocKb?=
 =?us-ascii?Q?3Roih1WV/1S+2xGrUtBgGOCqhmSWnzCjdchV66RzdRBD8Q+EhSHROc8bs3Ix?=
 =?us-ascii?Q?gRZ67Yx5VZwVdn4ANoKeN6kUoN25dyTVCcGKvxvZR6w0eqHyMunwtCcJR7EF?=
 =?us-ascii?Q?GrhrrLZsq3z+s05MKd8Q8wi7oXu4ZFJBkAiQ52uhj43o3w1uUzveyB2YkZK9?=
 =?us-ascii?Q?RHGHbPxGDxKTJfIvagAxJZxztTob+rT8rH9YIjQybhwFuwmosUL6I6VwTb5J?=
 =?us-ascii?Q?WO6wM75J1el7vSzCmp4lhVqapuObkVtR5R08HaKc1D8FiTR/NE1t1tIIjmhV?=
 =?us-ascii?Q?8fxrsSigrRrz5YpCb/C9jAIbs70xNXQokAJkwahW7Yn/7FUPlr09aPYC3o0M?=
 =?us-ascii?Q?DdP1AOvBMDzHmc4JAkPUzhrtmrIyDmElTY1Sv+GQjf1Wj8+QwdjRuNRTHJ5q?=
 =?us-ascii?Q?auSxoggcdyl5g+IrkASSgPAck8CS6lgSC7I5bhvJiISanr6s6nklq1MgzOHQ?=
 =?us-ascii?Q?PtBpH0e3JJiWZh/dYnraQ50iKOY+pd2FL4in42YB/rEocfDoP/SRKRe9rxlG?=
 =?us-ascii?Q?lFMBbe+zv0a6mKEWsG8a2d//mL/UnZhiPRT4LDNV5fXqRod8kpWbhqGJ5T/O?=
 =?us-ascii?Q?djdEniZBJwLV6xdu/fOrZgJ6sriVe7z8hKwcfAgiy1NiPpxj06l9IGiPu2SZ?=
 =?us-ascii?Q?i7oaQwtefSRYQK+MD9iTZpcO2T3afel6KnbQIkMd/ZpUtSZ7Og5LibHqNaig?=
 =?us-ascii?Q?6adyfF+WKhAqkhhhCwrl+iG4KQ4IEiAGR12Cezp1sIe7eNht6DzFbSDK/EJC?=
 =?us-ascii?Q?srXLXMgGx90Tpm49aelNQl2OFTgYoqEwvui1vf9H31bKgEOWP0MipStri7mz?=
 =?us-ascii?Q?RlOT3EViY+KyN6l1d+yDWv0l53uY2HlwpRKFRYmlj6QSG7CysHbcWKsdXp0D?=
 =?us-ascii?Q?q0LgCJeg2JpqPbIDuhZonjgGIQLG/0+oyRokooZl+K8EA2ob1ZCqB0T0lIKf?=
 =?us-ascii?Q?/ir9CAQNdkGpbGmlWewOBulGtZ/AiOL8rh4fuGOckVZSfn8XGHuV3H4WK4dq?=
 =?us-ascii?Q?ei/mQCQuJ1X047C1em1Iadq3lMWKKgc+Niqgkiw8pMLzatbGqYTK4xDik25p?=
 =?us-ascii?Q?hQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc5a9e4f-d050-42db-ac56-08d9d02a210f
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2022 09:02:41.0577
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A975re9hDVsFGyvl0YBKDImV0NgMoxaznJ9LYv7VY9Zwsf5k55bMoy/4UCwtjPkK6jWM+pV4PG88bzwMta92RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8831
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi

>=20
> >  			/* sai may support mclk/bclk =3D 1 */
> > -			if (of_find_property(np, "fsl,mclk-equal-bclk", NULL))
> > +			if (of_find_property(np, "fsl,mclk-equal-bclk", NULL))
> {
> >  				link_data->one2one_ratio =3D true;
> > +			} else {
> > +				int i;
> > +
> > +				/*
> > +				 * i.MX8MQ don't support one2one ratio,
> then
> > +				 * with ak4497 only 16bit case is supported.
> > +				 */
> > +				for (i =3D 0; i < ARRAY_SIZE(ak4497_fs_mul); i++)
> {
>=20
> Shouldn't this be keyed off checking that we are actually running with an
> ak4497?

No need. Here just update the ak4497_fs_mul table, before it is used the
codec type is checked.

Best regards
Wang Shengjiu