Date:   Wed, 5 Jan 2022 12:46:11 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Dave Hansen <dave.hansen@intel.com>,
        "David S. Miller" <davem@davemloft.net>
Cc:     Borislav Petkov <bp@alien8.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>, tglx@linutronix.de,
        mingo@redhat.com, luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/26] x86/tdx: Make pages shared in ioremap()
Message-ID: <20220105094611.kugiarylwjjjttkc@box.shutemov.name>
References: <YdMIWAT42el4D6wJ@zn.tnic>
 <20220103151516.pfcz2pap5l7r2rzv@box.shutemov.name>
 <b4b54116-1cd7-468a-0889-d497268cbfb2@intel.com>
 <20220103181059.ui5eloufw5gsojcb@box.shutemov.name>
 <20220104191424.oly2gqm4ltzj5wo3@box.shutemov.name>
 <0e0c38e2-67ad-1f51-c44b-d3c3d505e40a@intel.com>
 <20220105003108.mr7zyd5oyaaxmnmv@box.shutemov.name>
 <50dfa0db-fcd1-3c54-d982-237d2c9df431@intel.com>
 <20220105005720.zdtgwenqwqmuyxvi@box.shutemov.name>
 <4dc7d5e6-5b35-31ae-b5e9-7c77ed42383b@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4dc7d5e6-5b35-31ae-b5e9-7c77ed42383b@intel.com>
Precedence: bulk

On Tue, Jan 04, 2022 at 05:38:25PM -0800, Dave Hansen wrote:
> On 1/4/22 4:57 PM, Kirill A. Shutemov wrote:
> >> My read of STRICT_MM_TYPECHECKS was that "typedef unsigned long
> >> pgprot_t" produces better code, but "typedef struct { unsigned long
> >> pgprot; } pgprot_t;" produces better type checking.
> > Apart from pgprot_t, __pgprot() and pgrot_val() helpers are defined
> > differently depending on STRICT_MM_TYPECHECKS.
> > 
> >> I just compiled these patches on sparc with no issues.
> > Hm. I can't see how
> > 
> > #define pgprot_val(x)	(x)
> > 
> > can work to access value for the pgprot_t defined as a struct.
> 
> Oh, I must just be compiling with the strict type checks on all the
> time.  I do really wonder if these are useful these days or if the hacks
> were for ancient compilers.
> 
> In any case, this would be pretty easy to fix by just removing the
> !STRICT_MM_TYPECHECKS pgprot_val() and defning the STRICT_MM_TYPECHECKS
> universally.

There's comment in 32-bit Sparc as a reason for STRICT_MM_TYPECHECKS not
to be used:

/* passing structs on the Sparc slow us down tremendously... */

The comment came from before git times, so I don't know if it still has a
merit or newer compilers can deal with it better.

bloat-o-meter shows not trivial difference:

Total: Before=5342261, After=5344025, chg +0.03%

but I'm not sure if it translates into performance loss.

David, does the comment still relevant?

-- 
 Kirill A. Shutemov