Date:   Wed, 5 Jan 2022 10:52:53 +0000
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Christian =?utf-8?B?TMO2aGxl?= <CLoehle@hyperstone.com>
Cc:     "jason.wessel@windriver.com" <jason.wessel@windriver.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dianders@chromium.org" <dianders@chromium.org>,
        "corbet@lwn.net" <corbet@lwn.net>
Subject: Re: [PATCHv2] Documentation: kgdb: Replace deprecated remotebaud
Message-ID: <20220105105253.5x4zsve5vuxvzkzq@maple.lan>
References: <13287b7914344c7995de27224cd2fa73@hyperstone.com>
 <4050689967ed46baaa3bfadda53a0e73@hyperstone.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4050689967ed46baaa3bfadda53a0e73@hyperstone.com>
Precedence: bulk

On Wed, Jan 05, 2022 at 09:58:38AM +0000, Christian L?hle wrote:
> Using set remotebaud to set the baud rate was deprecated in
> gdb-7.7 and completely removed from the command parser in gdb-7.8
> (released in 2014). Adopt set serial baud instead.
> 
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>

Thanks for the update.

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

PS No need to worry about it this time around but, for future
   reference, if someone provides you one of the tags
   (Reviewed-By, Acked-By, etc) during a review cycle then you are
   normally expected to collect this and add them to tags section when
   you share the next version of the patch or, if there are big
   technical changes that make you choose to view the tag as
   out-of-date then drop the tag but mention why in the patch
   changelog.


> ---
>  Documentation/dev-tools/kgdb.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 43456244651a..7c90e111b364 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -557,7 +557,7 @@ Connecting with gdb to a serial port
>     Example (using a directly connected port)::
> 
>             % gdb ./vmlinux
> -           (gdb) set remotebaud 115200
> +           (gdb) set serial baud 115200
>             (gdb) target remote /dev/ttyS0
> 
> 
> --
> 2.34.1
> Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
> Managing Director: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782
>