Date:   Wed, 5 Jan 2022 11:55:44 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Baole Fang <fbl718@163.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Hui Wang <hui.wang@canonical.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
        Elia Devito <eliadevito@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Legion Y9000X 2020
Message-ID: <YdV5MNWOwgrtH2UC@kroah.com>
References: <20220105034103.12484-1-fbl718@163.com>
 <s5ha6gak2qf.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <s5ha6gak2qf.wl-tiwai@suse.de>
Precedence: bulk

On Wed, Jan 05, 2022 at 09:26:16AM +0100, Takashi Iwai wrote:
> On Wed, 05 Jan 2022 04:41:01 +0100,
> Baole Fang wrote:
> > 
> > commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream.
> 
> I couldn't find this commit.  Is this a bogus information?
> 
> > Legion Y9000X 2020 has a speaker, but the speaker doesn't work.
> > This can be fixed by applying alc285_fixup_ideapad_s740_coef
> >  to fix the speaker's coefficients.
> > Besides, to support the transition between the speaker and the headphone,
> > alc287_fixup_legion_15imhg05_speakers needs to be run.
> > 
> > Signed-off-by: Baole Fang <fbl718@163.com>
> 
> The code change itself looks fine, so I'd apply it if the line above
> can be omitted.

That commit id comes from 5.15.12, and it is the commit id of the
release commit:
	25960cafa06e ("Linux 5.15.12")
which makes no sense at all.

Baole, why did you add this line?

confused,

greg k-h