Date:   Wed, 5 Jan 2022 16:39:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Mihail Chindris <mihail.chindris@analog.com>,
        "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>, kernel@collabora.com,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers:iio:dac make expression evaluation 64-bit
Message-ID: <20220105133902.GD7674@kadam>
References: <YcIpAKV7Cmi0o7PU@debian-BULLSEYE-live-builder-AMD64>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YcIpAKV7Cmi0o7PU@debian-BULLSEYE-live-builder-AMD64>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ji2G3zxjrmKy/5rs1qLIUk4f+OFPkBZp2hVF89S/pcNY7t8b6nUFhmDv5xdh?=
 =?us-ascii?Q?56Yrs43VMGUQpTBFetlLECfOLP8EJr6HkLG7XF+O10NW8HKQM+pgQrSQ9OqA?=
 =?us-ascii?Q?dv1tvOHyhs0mz7NcfOCRgS+P0uLYoYiUG9MWnhOeJHupXWgAX3DgPxnWtQjD?=
 =?us-ascii?Q?IOVEnjWdUmX0OzTSrHe6wiFlMoQ+IKWZC3dak3jheGPW/hJsnTV9zbgpJD9B?=
 =?us-ascii?Q?feV1apuQUjr06phst8uMHm4oQoXfLXLMz+NrKqp7jvmCddcGyF9YWJ6brzOi?=
 =?us-ascii?Q?d51p4O31GoaJuz64Z3TvhvphexIZbcC2Vau/GqblQWLMct3has0KTmVXVgc8?=
 =?us-ascii?Q?HFtoQ6PL04bdBDy5laj9wpuBqiKZRE8wrFMIx1OUETqHw8ZIHj/sWURhkVlC?=
 =?us-ascii?Q?yquuzi2qt8rcp985T63FPl1Be6R8+0sVc/pC8sGGzfDlz4OlLukpKEe2zipb?=
 =?us-ascii?Q?IdVBBwTQfCnti4YCQRPVqybtfmMkO61C4JuaDLV+hP/u5zdLKwEwDiovDggk?=
 =?us-ascii?Q?E0U55HMqe31l6xnZU002DZ+sLZRvyu1mVWdRXuGqZvG3RFeuylqXe2OnDkV/?=
 =?us-ascii?Q?w0W5BqAt3RI8NLkrmqr4c93W6DGc4ZJtu2BNKm+GE7hWPBKXY9+0aIZkrfCQ?=
 =?us-ascii?Q?ayFli9G34Jmz2v/oSVPlR8uXmnT1KfkHJ1lvOzV3rdGqa3gb9+1aw2pW+5sM?=
 =?us-ascii?Q?kqSnUJEI11x88GufUidbuHg+gB7WlQUIVD8nFsnsu+cUxrp6iDASv7Je0Xu/?=
 =?us-ascii?Q?W/ge3ljqQ/7Z4AB5D2iuzvmbA4HB7bMmPoqvLg3RpOXvW384QGbbDZ+h6XfH?=
 =?us-ascii?Q?Mgvc1m06+eqOV1d0uOs7+wE2sfqhhVxwjXyUPgpkZ0TueNNgNXWOZUfKBQa8?=
 =?us-ascii?Q?l+o2C5btH7Rbgg4C/LBZYeJlr9jCXEK9s3QF7yeVUjweikyuaAt++wzKdFfn?=
 =?us-ascii?Q?xZiMIgZrm1da4miYD/37OBuBlQaZYZ4MRjUpZkQBzR/1quhKndw7DPZwG7GH?=
 =?us-ascii?Q?L0k//yhLHu6zRh4cefSP3YeYQhD2BexLAVRwQDgtfU7QHLf3yH+i0+5Z0jZq?=
 =?us-ascii?Q?FsRbzIh3ocVCBfD+BiGPIDJ5Gff8HaL+aT9M5eAsM5Dl7WJEz2hcCiYEZ3yR?=
 =?us-ascii?Q?0IOeEUPllsFxA4XiosvmKXWzdrfsbp5cucQTcCX2FoJawxcbDjfak2Qddt7s?=
 =?us-ascii?Q?Yvbz8aLkVOk/IVMjxi6u2bQgPsMK1zgesGnRHRHBi1TirGyXP+JHoU+BJb+h?=
 =?us-ascii?Q?JHSSgPsJQ36F6xFwswqgjgYtgmc0lPb+8Y1jTQsSfZGs6x3GC598Xw73VLrX?=
 =?us-ascii?Q?Ex63vKbvHg39allRC9USjxJyeoyisX2YqcZXESjVCMVxr6/N9hkJmsXAKeCM?=
 =?us-ascii?Q?+lLtaaCQRcAMWcI2XEmD2ay7hyTxq4BdPuvDVC79oyT4O0tuIhCDaa5/G7WH?=
 =?us-ascii?Q?+/UOPxtqsrnoLC0g7SUKLivGPGQ8EBDo7hI7NGnD5XNHR8OVGqVxRj/6N9Kk?=
 =?us-ascii?Q?P4nhO6sxTs8lTQbBXocq+/tnZbXPuU/tS55SIxaytTVSOLjGc5oXnaQBDCIg?=
 =?us-ascii?Q?8gBL9h6CU5TBfCfteOYgLovZ3DYPlkdwtUQByYrYZNzwvRhRcWmdPQhEyG//?=
 =?us-ascii?Q?zhmJKVi7t4ixnqpQMFfqYQ/dojUdhU5vu0i8Zvn4C0Oku6Q38ha+RyTimvir?=
 =?us-ascii?Q?Y8FM2bEHSW/tY8ioR68BFbVhGHs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ecb02e3-0381-4d7d-c99e-08d9d050c8a6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 13:39:23.8376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZkdiL0CRCISwPIjKvXrNbjJ8ST19KoWSspPQsTRfxICHl9U5u87rV//Ofa6NzNnrGBJxXNGu1AJwKT37UY2FDG5wPpfWDX+nlX7mLQKBGJA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1422
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10217 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 adultscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201050090
X-Proofpoint-ORIG-GUID: 9tLcv5wZbTQyjlUOPNP1vA-6CVqN0eQo
X-Proofpoint-GUID: 9tLcv5wZbTQyjlUOPNP1vA-6CVqN0eQo
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 22, 2021 at 12:20:32AM +0500, Muhammad Usama Anjum wrote:
> Two 32-bit values are being evaluated using 32-bit arithmetic and then
> passed to s64 type. It is wrong. Expression should be evaluated using
> 64-bit arithmetic and then passed.
> 
> Fixes: 8f2b54824b ("drivers:iio:dac: Add AD3552R driver support")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  drivers/iio/dac/ad3552r.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
> index 97f13c0b9631..b03d3c7cd4c4 100644
> --- a/drivers/iio/dac/ad3552r.c
> +++ b/drivers/iio/dac/ad3552r.c
> @@ -770,7 +770,7 @@ static void ad3552r_calc_gain_and_offset(struct ad3552r_desc *dac, s32 ch)
>  	dac->ch_data[ch].scale_dec = DIV_ROUND_CLOSEST((s64)rem * 1000000,
>  							65536);
>  
> -	dac->ch_data[ch].offset_int = div_s64_rem(v_min * 65536, span, &rem);
> +	dac->ch_data[ch].offset_int = div_s64_rem(v_min * 65536L, span, &rem);

"v_min" is relatively close to zero on a number line so this can't
overflow.  There is no way that this change affects anything at runtime
(except making the code a tiny tiny bit slower).

And it should be 65536LL for 32 bit systems?

But I just don't see the point of this change.  Presumably it is to make
a static analyzer happy?

regards,
dan carpenter