Date:   Wed, 5 Jan 2022 15:40:19 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Rob Herring <robh@kernel.org>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        openbmc@lists.ozlabs.org, Tomer Maimon <tmaimon77@gmail.com>,
        Joel Stanley <joel@jms.id.au>, linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Avi Fishman <avifishman70@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>
Subject: Re: [PATCH v3 4/9] dt-bindings: pinctrl: Add Nuvoton WPCM450
Message-ID: <YdWt0zUh4ds1xlPz@latitude>
References: <20211224200935.93817-1-j.neuschaefer@gmx.net>
 <20211224200935.93817-5-j.neuschaefer@gmx.net>
 <YdTGRY+n9XY522jg@robh.at.kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="AegnL8PRarm8VMMK"
Content-Disposition: inline
In-Reply-To: <YdTGRY+n9XY522jg@robh.at.kernel.org>
Precedence: bulk


--AegnL8PRarm8VMMK
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jan 04, 2022 at 04:12:21PM -0600, Rob Herring wrote:
> On Fri, Dec 24, 2021 at 09:09:30PM +0100, Jonathan Neusch=C3=A4fer wrote:
> > This binding is heavily based on the one for NPCM7xx, because the
> > hardware is similar. There are some notable differences, however:
> >=20
> > - The addresses of GPIO banks are not physical addresses but simple
> >   indices (0 to 7), because the GPIO registers are not laid out in
> >   convenient blocks.
> > - Pinmux settings can explicitly specify that the GPIO mode is used.
> >=20
> > Certain pins support blink patterns in hardware. This is currently not
> > modelled in the DT binding.
> >=20
> > Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
> >=20
> >=20
> > ---
[...]
> > +patternProperties:
> > +  # There are three kinds of subnodes:
> > +  # 1. a GPIO controller node for each GPIO bank
> > +  # 2. a pinmux node configures pin muxing for a group of pins (e.g. r=
mii2)
> > +  # 3. a pinconf node configures properties of a single pin
> > +
> > +  "^gpio":
>=20
> '^gpio@[0-7]$'

Makes sense, I'll change it.

> > +    type: object
> > +
> > +    description:
> > +      Eight GPIO banks (gpio@0 to gpio@7), that each contain between 1=
4 and 18
> > +      GPIOs. Some GPIOs support interrupts.
> > +
> > +    properties:
> > +      reg:
> > +        description: GPIO bank number (0-7)
>=20
> reg:
>   minimum: 0
>   maximum: 7
>=20
> But there's not an actual register address range you could use instead?

Unfortunately no, not easily.

The GPIO bank specific registers are not arranged in a regular pattern,
so the address/offset of the first register in a bank does not suffice
to know the addresses of all other registers. Instead, different banks
support slightly different functionality (e.g. power source configurations
or automatic blinking), and the registers were crammed into the register
space as tightly as possible.

The full table of register offsets is in the driver, and for the
aforementioned reasons, a full table is necessary.


Thanks,
Jonathan Neusch=C3=A4fer

--AegnL8PRarm8VMMK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmHVra8ACgkQCDBEmo7z
X9suOg/+ODrZdL9EHnUWYJXMx2NcBGgtpeypbvXtcEfuPE2jhg27RuwrCccE5BFY
Hdkmv9t9RpTdHebQ/w8T53GB7CcrBM6scBrbQiYTIY51U5yeycOEUT6ZNpWtm62X
Vkzwx7hPEqb3uieuHHSZ8sxtVOGr/FgH7VUS7c+M/MyJlvzhc6KfatBqfc3KnXth
XPKVFBd6zDScfCHcmsc4FDwBsmktKWZ66c1BwEMrKHwwzNkDJ3GDdKOSdc/KgUL4
ASo1DFAi3dwp+J24iCEMm3JroaujJC0qdmWGBhZAyT90g3Rc9DgZ+wpCQXwgElP9
/1UUWLRUa8XYBd0CWnHC+GVllVugNoAusagCe/GiNngEOoYat3XEvzuw155oqjMA
NRKf9KuB+n4SQlnYkdg3IomnMca378Dm02mU0bvSOajj6kH7ziTXNOe3DuGemoq1
wDhdHtxEHjtcTue9CVBSem5Pt9zzyerJrOIN6xnWaPXqTwD8Bw2x+U4IvfrJ5Up5
XPQn9h1dTDElSDSRaGidKJi4QH14w9ubBUMBlphAuVM1rhEDDMMUX5wmLjB3gqTC
74MICrHDtcNYbtbZUzcXtapY7DN5BQnOIK2HPDJpNI/+0BWcwkdTk8syZqYFiRoc
9fsEGDBJwYRipphIbkXf6lp/o1yGUH79nVPhtyN9UnNuIvdL+8Y=
=PgLj
-----END PGP SIGNATURE-----

--AegnL8PRarm8VMMK--