MIME-Version: 1.0
References: <20220103043202.6524-1-yc.hung@mediatek.com>
In-Reply-To: <20220103043202.6524-1-yc.hung@mediatek.com>
From:   Daniel Baluta <daniel.baluta@gmail.com>
Date:   Wed, 5 Jan 2022 17:53:51 +0200
Message-ID: <CAEnQRZBH4uwMmyBLY2bCtY9QZooBiK5PqF3T+4K8WAtQV1QN-Q@mail.gmail.com>
Subject: Re: [PATCH v3] dt-bindings: dsp: mediatek: add mt8195 dsp document
To:     YC Hung <yc.hung@mediatek.com>
Cc:     Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Rob Herring <robh+dt@kernel.org>, matthias.bgg@gmail.com,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        Daniel Baluta <daniel.baluta@nxp.com>, trevor.wu@mediatek.com,
        allen-kh.cheng@mediatek.com,
        Cezary Rojewski <cezary.rojewski@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 3, 2022 at 1:00 PM YC Hung <yc.hung@mediatek.com> wrote:
>
> From: "YC Hung" <yc.hung@mediatek.com>
>
> This patch adds mt8195 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers,  clocks, memory regions,
> and mailbox for dsp.
>
> Signed-off-by: yc.hung <yc.hung@mediatek.com>

The code patch should be created against original source code from
Rob's tree. Here it seems the patch is against v2.

This isn't going to work! Because when Rob will try to apply the patch
it will fail since he doesn't have (and doesnt need to have)
your previous versions.

So, please keep the changes history (that's a good thing!) but always
rebase your patch on maintainer's tree.


> ---
> Changes since v2:
>   Remove useless watchdog interrupt.
>   Add commit message more detail description.
>
> Changes since v1:
>   Rename yaml file name as mediatek,mt8195-dsp.yaml
>   Refine descriptions for mailbox, memory-region and drop unused labels
>   in examples.
> ---
> ---
>  .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index bde763191d86..779daa786739 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -27,14 +27,6 @@ properties:
>        - const: cfg
>        - const: sram
>
> -  interrupts:
> -    items:
> -      - description: watchdog interrupt
> -
> -  interrupt-names:
> -    items:
> -      - const: wdt
> -
>    clocks:
>      items:
>        - description: mux for audio dsp clock
> @@ -75,8 +67,6 @@ required:
>    - compatible
>    - reg
>    - reg-names
> -  - interrupts
> -  - interrupt-names
>    - clocks
>    - clock-names
>    - memory-region
> @@ -95,8 +85,6 @@ examples:
>         reg = <0x10803000  0x1000>,
>               <0x10840000  0x40000>;
>         reg-names = "cfg", "sram";
> -       interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
> -       interrupt-names = "wdt";
>         clocks = <&topckgen 10>, //CLK_TOP_ADSP
>                  <&clk26m>,
>                  <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
> --
> 2.18.0
>