Subject: Re: [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, alexander.deucher@amd.com,
        christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220105090943.2434040-1-jiasheng@iscas.ac.cn>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <3a1a14b9-3bde-ed44-ea43-42845f4b568f@amd.com>
Date:   Wed, 5 Jan 2022 10:56:51 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220105090943.2434040-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjVNUXJBTERjbkFxeThMaTZvMXlPeUdwWjEvV2NVYWhQV3BBNy9BYms1bGdu?=
 =?utf-8?B?cnNGbEZBRDVsaU1xREVkSkUxdzhOeTZ6d21RTjhwYmw2WGFsc3NBSjU2SWVu?=
 =?utf-8?B?MUdEbjRsYXdBQjgzbG9HZ0pkbHVBK1c0bERaSVZzbkh6M1ZXaUJtc2FZVFQ4?=
 =?utf-8?B?dm9sV0U3dDNtajRkaFljTndiU25Ed3czTE5hOW1mcDU4RWJlM0dUUkFFZGpm?=
 =?utf-8?B?dmIwR3owWXR2cEZrZlhncmk4RzFDV2l5a3ZTRjlicUorMnlEUUpDSXN6VmUw?=
 =?utf-8?B?amtuRTBnSmkyWkpaa3dNSi90Z1B6eFRhbk1nTFhHR3RFeHA1ZXV3bTBpOE9Z?=
 =?utf-8?B?dmd6NkhWYlBGYVZpYXA0MHFtWU1uZ0cxbkIwazNobzQ2cWYxcWEvdnFoMjA2?=
 =?utf-8?B?a1VQR0VYcVRrZFNMVU9IQTYyNENrNGxmcGRuR1RCRFFZOFZ6UTJ1WXkwUTlo?=
 =?utf-8?B?aTcrQnJ3VFdpRkxieDc2YUgvMnhVeVF2ZXUyVnF5NTVhZVptYXFzazAzeU01?=
 =?utf-8?B?RWJHZFM3WE9PWGV6K1hYVGVvQUZnN3lWT0lsSE5aeFI3M3RhSVk0cXpLMFdx?=
 =?utf-8?B?QU5MZ2JyUUVoTmowcEFiVmpwUzE3bGJwSW05cTBiWHpJckpWb0UyUm9ub01I?=
 =?utf-8?B?WDdxK011MGp0TFpYd0Q1Ri9MZUlBVG1qSklGTlU5eDlVNWttS0Z3WDJRNjE1?=
 =?utf-8?B?OGd0eWZLVE1yWEk0OEw3b3ROV3A0MURFbFZUZGhWVzQ2OWFibzFLV01TanQv?=
 =?utf-8?B?eWlSeW5wVytPTWNkaE03d2ZNN0hqYm1uOFFvQ2FKaS94TDc0ZU12bkNhT004?=
 =?utf-8?B?eGhJUHhPcVl0VUhzczN1bUJsd1ZCSno2R0N2aFkyMHpJeHE4eDhvRmp5NkFy?=
 =?utf-8?B?czUvZHR2TGEzRGY5VEJabFRCN2JzU3lLY1JmK3BOZFBsQ3pndTlsYWtXYU5l?=
 =?utf-8?B?WjZaVFUzU2MrZWV6NXhPSG1OL1dqVHg4ZUtqeHR4dDhvcW1yQ2NzWDNYSWpI?=
 =?utf-8?B?b0UvR1NiVVlXZlJiUmR0SU1qdUFlT3VpU1BnSjc3TjVkN0pDYzVRNE1TMVRo?=
 =?utf-8?B?NGtSVXh1Um4yNU9TMyt2MXhweTFMTGlrN0dWZnMwWFdWaEtkTEdWN1g0N2pX?=
 =?utf-8?B?K2RUS3lhZEJBVTdsWHE4ZGh1SG1WaXJYT05LbEh6U2h1K3BNUGtNaXlQUjZX?=
 =?utf-8?B?eWdMV0lPL3VRK1hGMjBPa09tcitvcExEU1lySXlKWSsyYkN4TmNtQ2ZPUzJi?=
 =?utf-8?B?dE85cXhBV2JmNnFpNE5uNjMxRXdRT0Q2VHk1eG9neVJqanVqdW1wTGlHOWNp?=
 =?utf-8?B?bGc2U1hkY3cvVStkbnZJNXRiT2JEaEdYUFRzZEUxdkdqOEZvd25Kb1UwOEIv?=
 =?utf-8?B?MGZlNit5MjZQeHdlYjgrb1BhclpoQUNwOWlDWUUzUTNEVHBXL0I1T0V3Ujht?=
 =?utf-8?B?VGJyamdRbmFPNi8rMTBRRWVjdmFNaUpUdDdVMmtzS2ZSenFVWTBhSlU2T21Z?=
 =?utf-8?B?Q1RwU1ovaXRHUjV6WjJNOEtHSVl3QzJkeDEzLzJuSGhMam8yVDRmV2ZTNXNq?=
 =?utf-8?B?MSs2TytqM1lMeDIvMnc4eEQvR3NPRTBTV1N0TURRMWxkSG00cDNnOFRhRVoy?=
 =?utf-8?B?cE5JV2ZTWXRKUWNBK09adnRUTEppbDVBUGR5TUlDbk1OWktsUXlLQmtURVIy?=
 =?utf-8?B?elYwUmRCcXBjU1JHMFJrMmZGR3NoQ1pBSFBoc0JHb0xZY0llc3dZNzVYRGtx?=
 =?utf-8?B?M1pzeFFmUkdNME5MK3k2VGp3Nk1yOWhUekpkeHl0T1orbExCUjFoeUE1cEl5?=
 =?utf-8?B?MDd3NmhYb1RLUGJQcU42d0pwbnA4MnNTeERkbkZzeWxIZDhUNTlkM1grTjM0?=
 =?utf-8?B?SVFMSHlwYUM2MzRUQ1U1a24waFJCZFVGdzgwWkVJc2k1bUV0M1hYUnBrWWx4?=
 =?utf-8?B?TXl4VkpEQkdiSnM0akl0RTZGbTdHTEJRWXluakZ5SVNjMGQ3d1AwRzdYdXlT?=
 =?utf-8?B?NG9MbjZaT2VONVNOdWlEdHpsOVV0Tm02aG81MDExenBBb1duVlhJMnV4eTdC?=
 =?utf-8?B?M0x2Q2hHK2xNZ3YrSmR0U0FqNTlrRDhhZGJJYU9BbmMwbmI4MENYLzlYV2Rs?=
 =?utf-8?B?NGVMT1BNZmtKbGZGcWJwRHpzZWRnNksxREp0ODhOekFOUEJqcUZoOC9oUU13?=
 =?utf-8?Q?2eOQBjgArYPvnHirNc6SRQI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4da29fe-8e52-48c6-059b-08d9d063fe07
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 15:56:53.3567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 76DP1R7qo21/vZe8lQLm5xRncux1Qbksns7uzYPZ32ue3QrlttuvTWafUFvDS9NMB33wOKTj4ks6XJX73dH6Og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5273
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2022-01-05 um 4:09 a.m. schrieb Jiasheng Jiang:
> As the possible failure of the allocation, kmemdup() may return NULL
> pointer.
> Therefore, it should be better to check the 'props2' in order to prevent
> the dereference of NULL pointer.
>
> Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index c60e82697385..d15380c65c6d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -410,6 +410,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
>  			return -ENODEV;
>  		/* same everything but the other direction */
>  		props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL);
> +		if (!props2)
> +			return -ENOMEM;
> +
>  		props2->node_from = id_to;
>  		props2->node_to = id_from;
>  		props2->kobj = NULL;