Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbXAaArL (ORCPT ); Tue, 30 Jan 2007 19:47:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752135AbXAaArL (ORCPT ); Tue, 30 Jan 2007 19:47:11 -0500 Received: from rtr.ca ([64.26.128.89]:1079 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbXAaArJ (ORCPT ); Tue, 30 Jan 2007 19:47:09 -0500 From: Mark Lord To: linux-kernel@vger.kernel.org, "IDE/ATA development list" , James Bottomley Subject: [PATCH] scsi_lib.c: continue after MEDIUM_ERROR Date: Tue, 30 Jan 2007 19:47:08 -0500 User-Agent: KMail/1.9.4 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701301947.08478.liml@rtr.ca> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 41 In ancient kernels, the SCSI disk code used to continue after encountering a MEDIUM_ERROR. It would "complete" the good sectors before the error, fail the bad sector/block, and then continue with the rest of the request. Kernels since about 2.6.16 or so have been broken in this regard. They "complete" the good sectors before the error, and then fail the entire remaining portions of the request. This is very risky behaviour, as a request is often a merge of several bios, and just because one application hits a bad sector is no reason to pretend that (for example) an adjacent directly lookup also failed. This patch fixes the behaviour to be similar to what we had originally. When a bad sector is encounted, SCSI will now work around it again, failing *only* the bad sector itself. Signed-off-by: Mark Lord --- diff -u --recursive --new-file --exclude-from=linux_17//Documentation/dontdiff old/drivers/scsi/scsi_lib.c linux/drivers/scsi/scsi_lib.c --- old/drivers/scsi/scsi_lib.c 2007-01-30 13:58:05.000000000 -0500 +++ linux/drivers/scsi/scsi_lib.c 2007-01-30 18:30:01.000000000 -0500 @@ -865,6 +865,12 @@ */ if (sense_valid && !sense_deferred) { switch (sshdr.sense_key) { + case MEDIUM_ERROR: + // Bad sector. Fail it, and then continue the rest of the request: + if (scsi_end_request(cmd, 0, cmd->device->sector_size, 1) == NULL) { + cmd->retries = 0; // go around again.. + return; + } case UNIT_ATTENTION: if (cmd->device->removable) { /* Detected disc change. Set a bit - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/