In-Reply-To: <20070130211153.4ca1aaa7.akpm@osdl.org>
References: <Pine.LNX.4.64.0701302251520.5644@localhost.localdomain> <20070130211153.4ca1aaa7.akpm@osdl.org>
Mime-Version: 1.0 (Apple Message framework v752.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <6543410C-B60C-4706-AB4E-FA64C4E592F5@kernel.crashing.org>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org,
       linux-pci@atrey.karlin.mff.cuni.cz
Content-Transfer-Encoding: 7bit
From: Kumar Gala <galak@kernel.crashing.org>
Subject: Re: Reducing warning output from pci_get_subsys()
Date: Tue, 30 Jan 2007 23:18:21 -0600
To: Andrew Morton <akpm@osdl.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1116
Lines: 38


On Jan 30, 2007, at 11:11 PM, Andrew Morton wrote:

> On Tue, 30 Jan 2007 22:55:38 -0600 (CST)
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
>> Greg,
>>
>> There was some code added to warn if pci_get_subsys() is called  
>> and the
>> pci_devices is empty.
>>
>> I'm wondering if there is some point at which we know its ok for the
>> pci_devices list be empty if there are no devices on the bus so we  
>> can
>> stop printing the message.
>>
>> On an embedded PPC reference system I see this message 6 times  
>> when I've
>> got no cards in the PCI slots.
>>
>
> I'd suggest we just remove the warning.  Also the one in  
> pci_find_subsys().
>
> I let them go through because I was curious to know what would  
> cause it to
> trigger - it might be an indication of other bugs.  But nothing very
> interesting happened and they're of no use.

Works for me.

- k
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/