Message-ID: <45C07275.9010501@garzik.org>
Date: Wed, 31 Jan 2007 05:41:57 -0500
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 1.5.0.9 (X11/20061219)
MIME-Version: 1.0
To: Divy Le Ray <None@chelsio.com>
CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       swise@opengridcomputing.com, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
References: <20070131034424.8651.4713.stgit@localhost.localdomain>
In-Reply-To: <20070131034424.8651.4713.stgit@localhost.localdomain>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 796
Lines: 21

Divy Le Ray wrote:
> From: Divy Le Ray <divy@chelsio.com>
> 
> Offload packets may be DMAed long after their SGE Tx descriptors are done
> so they must remain mapped until they are freed rather than until their
> descriptors are freed.  Unmap such packets through an skb destructor.
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>

this is questionable and sounds like you are working around a bug.  I 
can't think of another driver that uses skb destructors, and I could 
have sworn that skb destructors were not for drivers to use anyway

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/