Date: Wed, 31 Jan 2007 13:43:00 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, johnstul@us.ibm.com,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 23/23] clocksource tsc: add verify routine
Message-ID: <20070131124300.GG1847@elte.hu>
References: <20070131033710.420168478@mvista.com> <20070131033810.319576375@mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070131033810.319576375@mvista.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1029
Lines: 34


* Daniel Walker <dwalker@mvista.com> wrote:

> I've included this as another user of the clocksource interface. I 
> don't see a usage for this across all achitectures. So a fully generic 
> version isn't needed.

well, this implementation is buggy in at least two ways:

firstly, it allows a circular verification dependency in highres+dyntick 
mode between the jiffies and tsc clocksources.

secondly, verification is not done while the system is booting up:

>  static void verify_tsc_freq(unsigned long unused)
>  {

[...]
> +	if (unlikely(system_state != SYSTEM_RUNNING))
> +		goto out_timer;

so we should just go with Thomas' patch:

  clocksource-add-verification-watchdog-helper.patch

which has been based on and tested on actual systems affected by these 
problems.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/