Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933231AbXAaOAE (ORCPT ); Wed, 31 Jan 2007 09:00:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933275AbXAaOAE (ORCPT ); Wed, 31 Jan 2007 09:00:04 -0500 Received: from an-out-0708.google.com ([209.85.132.250]:56325 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933231AbXAaOAC (ORCPT ); Wed, 31 Jan 2007 09:00:02 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DMZmTWNJenzq3RUmEqH67FwabFYUzdf0XTwWeu1ZTzVPxEgYB1/fqECWNpeZkmCSt2UZLpENi4FkTNlawYipkAJM5Q7GC+ysivV+ALLOvYIsHpDXFXCmOsCqa88aus0QhncAEdTg5fhoj8tu0wO6YJSfCd53mlMVbNbrSuJeVPE= Message-ID: <6bffcb0e0701310600s192f462aw18c96dce5630fe25@mail.gmail.com> Date: Wed, 31 Jan 2007 15:00:00 +0100 From: "Michal Piotrowski" To: "Robert P. J. Day" Subject: Re: [PATCH] Centralize the selection for debugging semaphores. Cc: "Linux kernel mailing list" , dhowells@redhat.com, rth@twiddle.net In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <6bffcb0e0701310544w474810cfh83fbfa539e1c0573@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 52 On 31/01/07, Robert P. J. Day wrote: > On Wed, 31 Jan 2007, Michal Piotrowski wrote: > > > On 31/01/07, Robert P. J. Day wrote: > > > > > > Centralize the kernel config option for debugging semaphores and > > > modify the macro for frv to use that config option instead. > > > > > > Signed-off-by: Robert P. J. Day > > [..] > > > +config DEBUG_SEMAPHORE > > > + bool "Semaphore debugging" > > > + depends on DEBUG_KERNEL > > > + default n > > > + help > > > + If you say Y here then semaphore processing will issue lots of > > > + verbose debugging messages. If you suspect a semaphore problem or > > > a > > > + kernel hacker asks for this option then say Y. Otherwise say N. > > > + > > > + At the moment, this is implemented only by alpha and frv. > > > > IMHO this option should stay in arch/{alpha,frv}/Kconfig.debug > > any particular reason? Only this "At the moment, this is implemented only by alpha and frv." It depends on architecture. > and note that it's currently *not* in > arch/frv/Kconfig.debug -- it's hard-coded with a macro name that's not > the same as the config option, and i don't really see the advantage of > having each architecture implement precisely the same feature in > different and incompatible ways. but i'm willing to be convinced > otherwise. > > rday Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (http://www.stardust.webpages.pl/ltg/) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/