Message-ID: <45C0AF6B.4020406@qumranet.com>
Date: Wed, 31 Jan 2007 17:02:03 +0200
From: Avi Kivity <avi@qumranet.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20061219)
MIME-Version: 1.0
To: akpm@osdl.org
CC: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       mingo@elte.hu
Subject: Re: [PATCH] KVM: Fix lockup on 32-bit intel hosts with nx disabled
 in the	bios
References: <20070131150017.020B9A0014@il.qumranet.com>
In-Reply-To: <20070131150017.020B9A0014@il.qumranet.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1199
Lines: 36

Avi Kivity wrote:
> Intel hosts, without long mode, and with nx support disabled in the bios
> have an efer that is readable but not writable.  This causes a lockup on
> switch to guest mode (even though it should exit with reason 34 according to
> the documentation).
>
>   

Andrew, I believe this is 2.6.20 material.

> Signed-off-by: Avi Kivity <avi@qumranet.com>
>
> Index: linux-2.6/drivers/kvm/vmx.c
> ===================================================================
> --- linux-2.6.orig/drivers/kvm/vmx.c
> +++ linux-2.6/drivers/kvm/vmx.c
> @@ -1128,6 +1128,8 @@ static int vmx_vcpu_setup(struct kvm_vcp
>  
>  		if (rdmsr_safe(index, &data_low, &data_high) < 0)
>  			continue;
> +		if (wrmsr_safe(index, data_low, data_high) < 0)
> +			continue;
>  		data = data_low | ((u64)data_high << 32);
>  		vcpu->host_msrs[j].index = index;
>  		vcpu->host_msrs[j].reserved = 0;
>   


-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/