MIME-Version: 1.0
References: <YbufNsBtiIzbm+9k@robh.at.kernel.org> <20211217144544.7147-1-akingchen@vivo.com>
In-Reply-To: <20211217144544.7147-1-akingchen@vivo.com>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 5 Jan 2022 10:47:43 -0600
Message-ID: <CAL_JsqKnGj0ocLS6sOc2aryh4QwQqbO8Zo4CctgfYYWTnbmxNQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split_quirk
 property in dwc3
To:     Yaqin Pan <akingchen@vivo.com>
Cc:     Felipe Balbi <balbi@kernel.org>, devicetree@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kernel@vivo.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux USB List <linux-usb@vger.kernel.org>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 17, 2021 at 8:46 AM Yaqin Pan <akingchen@vivo.com> wrote:
>
> >> >> Add snps,dis_split_quirk property for dwc3 controller
> >> >>
> >> >> Signed-off-by: Yaqin Pan <akingchen@vivo.com>
> >> >> ---
> >> >>   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
> >> >>   1 file changed, 6 insertions(+)
> >> >>
> >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >> >> index 41416fbd92aa..e9615ca8f447 100644
> >> >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >> >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >> >> @@ -226,6 +226,12 @@ properties:
> >> >>         avoid -EPROTO errors with usbhid on some devices (Hikey 970).
> >> >>       type: boolean
> >> >>   +  snps,dis_split_quirk:
> >
> >I'm tired of the never ending DWC3 quirks. Imply this from the
> >compatible unless it varies by board.
>
> Yes, this is a DWC3 controller compatible issue.

Again, imply this from the compatible STRING (or the compatible string
of the parent node). I don't really want to see more quirk properties
unless they are board or instance specific (meaning for a given SoC,
the setting varies).

What is the downside to always setting this bit in the controller even
if not needed? Answer that question in your commit message.

Rob