Date:   Wed, 5 Jan 2022 13:00:10 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Maor Gottlieb <maorg@nvidia.com>
Cc:     alaa@nvidia.com, chuck.lever@oracle.com,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        tonylu@linux.alibaba.com, leon@kernel.org
Subject: Re: [PATCH rdma-rc] Revert "RDMA/mlx5: Fix releasing unallocated
 memory in dereg MR flow"
Message-ID: <20220105170010.GA2809962@nvidia.com>
References: <20211222101312.1358616-1-maorg@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211222101312.1358616-1-maorg@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vi0bVuNarF5ra4qXcs/Nbb7B/50X3Zv/PlE2Xs8i/oRshSFYM9W6p0uezpTz?=
 =?us-ascii?Q?3QBT3MFcs58x2Jx5xTYdHGJOBc/RUu5RLjQByGxHAkh6Wcc0uU0fuNCN5zkn?=
 =?us-ascii?Q?JRVdXqPBO/zMfNwogwCtLWIgEtxNiuSsMlSis3/rdrTW+qyYF1gKYPnhWXD0?=
 =?us-ascii?Q?EppnT/KFD+UC7aHezCAH6s3xY6e1xmynbtab+MJAp1T4jpwd8j7gvvlXNp6+?=
 =?us-ascii?Q?+2+ezhWH4ToMhL3dzhVy3LCCyXeOXcT1Xa4G6prScDbWwujVtdEGcQsv5zxi?=
 =?us-ascii?Q?4HOPJNPLxf0wqA0K5O6chPdSwfXF4YktWPIubI5HzYr3hntrhaOIPIk8fnzY?=
 =?us-ascii?Q?Q8G/0aajuU5KaRNImQ2V80G0Jqmn2gqXjhmYt2iBt1mSNLLlOgRVrneO3q+M?=
 =?us-ascii?Q?vRg67nJU68RjXBwtpvZzpYLBZKeCe7rirUzTMdoTNe7QkzneauLhHwEGX7Yr?=
 =?us-ascii?Q?BHLFQ3wyfr0MRV+4PsVMkw7DSJ91EP6Hrg7yaFifY6I2M5VZCJVSYFqtSMPl?=
 =?us-ascii?Q?+ZGVlgZeqAGbeDdzCHCaEW7HNvVfKiyMhaJC4LUDznsDnW+AeGkgNkWL65Y0?=
 =?us-ascii?Q?TjXAu9EjqyDbRq7L232oVnh1yD6vTSUbXUNkcKAaw1lB8miOOWc1HnepWGsw?=
 =?us-ascii?Q?iM7cT37chcLokmxapevP2pN5c7yJMWqimM+yvNFoLQrCo/kfpCHZEYl5SjIC?=
 =?us-ascii?Q?JWrcE0dJ+RZIAimIvw5LU10+Fva3hO/pgs211LM6ZrezDP+9GjtaME7oSnde?=
 =?us-ascii?Q?irl1DE6Gb6xtaftc9UQHCXchqdjyTVJaKz5ne/0sWXzhIGhgCT47EGnJNxyk?=
 =?us-ascii?Q?uijDHHEkXI00T8Y5fdZE1qHBHJf1pLtvKomz8GPIxcc2N2wJaomCljf3jBCk?=
 =?us-ascii?Q?jjVu4TaPMjJ6txSrFhQ2I853uUMGnX249ZaiI/bLGwBtt7Io2TaSPXE9gCFS?=
 =?us-ascii?Q?C4PI3+6zD8i+Cv5mfF72eX7I7x/SO9YkrVQzFlQq4QxyXGmzxxU9XZHaZIiw?=
 =?us-ascii?Q?SLOiaHpOxTCcT46I2iUK72UdY2uOEN6WvCkVlJ0R1lebeHxrL7TyQNcyL31x?=
 =?us-ascii?Q?xBVaBgB1Ksg42ttIWTmhvF67nEF0BAWcwsZCdhTTMyt7+mW1lUsLpGv11xg4?=
 =?us-ascii?Q?lL4GTHQkx5/o1O5paxzUv5XyK9Wo7SwQ6zoxQfXFAtYtHPVMhYhEgIr4jBTC?=
 =?us-ascii?Q?hOrwIrHyGdNZEUurudLpIKsk3pNRu/QqB86r6MTYhSQgbBs5CNJ+FABy3gmf?=
 =?us-ascii?Q?Xocg67k/KueLtVjcAWylqEAwydiyuPnSGD+cVyMRweDueM0MXWP7etnvNJ6U?=
 =?us-ascii?Q?JxeGD16HLQQHcd0+jRNRLzQU0x2hz4FVe/flI2i+OetpvrtjEpKixg+UU/jh?=
 =?us-ascii?Q?R8v3I2J58R4Ix9z1/gf6YnxeFaRlMGOLwzSQFJCeRxeznasSfF6FjQACKu6z?=
 =?us-ascii?Q?PJv/KbewrQG40h+O+OuWK5RC0QRadvfAb027qWSfPeDyWbg4TbcpmRJcqzHT?=
 =?us-ascii?Q?JpgpBldMqVI+ojQVd9N+r87Oj8FWrALr5+CEcD7MsoWx61wy+6AOdoSLhEb7?=
 =?us-ascii?Q?qoeALa7NL2PdaaoP5LQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac110c1a-da3c-4d3d-f02d-08d9d06cd7d1
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 17:00:14.8196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oi+ZA/hOMxBo32mSVYd7yQ3ebimfmQHj2Og6vPE92W88kdqYNHFfqLSjJVoUpuPC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5240
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 22, 2021 at 12:13:12PM +0200, Maor Gottlieb wrote:
> This patch is not the full fix and still causes to call traces
> during mlx5_ib_dereg_mr().
> 
> This reverts commit f0ae4afe3d35e67db042c58a52909e06262b740f.
> 
> Fixes: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
> Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
> Acked-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/hw/mlx5/mlx5_ib.h |  6 +++---
>  drivers/infiniband/hw/mlx5/mr.c      | 26 ++++++++++++++------------
>  2 files changed, 17 insertions(+), 15 deletions(-)

Applied to for-rc, lets get the correct fix for the next cycle.

Thanks
Jason