Message-ID: <211edcb700db30c4a6b37db87139e5fa47aeece0.camel@mengyan1223.wang>
Subject: Re: [PATCH V5 00/22] arch: Add basic LoongArch support
From:   Xi Ruoyao <xry111@mengyan1223.wang>
To:     Huacai Chen <chenhuacai@gmail.com>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Date:   Thu, 06 Jan 2022 01:21:46 +0800
In-Reply-To: <6d0169ca8c9e417308d3b9f96cd0ef446ee36fe7.camel@mengyan1223.wang>
References: <20211013063656.3084555-1-chenhuacai@loongson.cn>
         <722477bcc461238f96c3b038b2e3379ee49efdac.camel@mengyan1223.wang>
         <CAAhV-H40oWqkD+tQ3=XA8ijQGukkeG5O1M1JL3v5i402dFLK+Q@mail.gmail.com>
         <587ab54d77af2fb4cdbe0530cdd5e550c3e968db.camel@mengyan1223.wang>
         <CAAhV-H6R=xWL18AH7HzeXHOVD_d-5m7RvdQCLkOR1NeDZ_0HMw@mail.gmail.com>
         <6d0169ca8c9e417308d3b9f96cd0ef446ee36fe7.camel@mengyan1223.wang>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2022-01-05 at 19:51 +0800, Xi Ruoyao wrote:
> On Wed, 2022-01-05 at 17:40 +0800, Huacai Chen wrote:
> > Hi, Ruoyao,
> > 
> > The problem still exists in 5.16-rc8, can you try to change
> > cpu_relax() definition to smp_mb()? It seems can fix the problem.
> 
> Is there any workload which can triggers the panic?  I can't trigger it
> by building and testing GCC, or building the kernel anymore.
> 
> And is your "stable" issue the same one I'd encountered?  To me changing
> barrier() to smp_mb() may fix some deadlock, but not a panic.  (I'm not
> an expert on CPU architecture or kernel programming, so maybe I'm wrong
> here.)
> 
> I'll put my 3A5000 machine into a loop building kernel and see if I can
> trigger the panic again...

I can't reproduce the issue on 5.16-rc8.  But I can reproduce it on
5.16-rc5 and the s/barrier/smp_mb/ change fixes the issue.

I'm still puzzled: if there some workload which can reproduce the issue
more deterministic?
-- 
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University