Date:   Wed, 5 Jan 2022 18:36:15 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Aaron Ma <aaron.ma@canonical.com>
Cc:     Oliver Neukum <oneukum@suse.com>, kuba@kernel.org,
        henning.schild@siemens.com, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, hayeswang@realtek.com, tiwai@suse.de
Subject: Re: [PATCH] Revert "net: usb: r8152: Add MAC passthrough support for
 more Lenovo Docks"
Message-ID: <YdXXD3us3RnCuw4y@lunn.ch>
References: <20220105155102.8557-1-aaron.ma@canonical.com>
 <394d86b6-bb22-9b44-fa1e-8fdc6366d55e@suse.com>
 <fa192218-4fc8-678f-8b40-95b85e36097e@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fa192218-4fc8-678f-8b40-95b85e36097e@canonical.com>
Precedence: bulk

On Thu, Jan 06, 2022 at 12:05:28AM +0800, Aaron Ma wrote:
> 
> On 1/6/22 00:01, Oliver Neukum wrote:
> > 
> > On 05.01.22 16:51, Aaron Ma wrote:
> > > This reverts commit f77b83b5bbab53d2be339184838b19ed2c62c0a5.
> > > 
> > > This change breaks multiple usb to ethernet dongles attached on Lenovo
> > > USB hub.
> > 
> > Hi,
> > 
> > now we should maybe discuss a sensible way to identify device
> > that should use passthrough. Are your reasons to not have a list
> > of devices maintainability or is it impossible?
> > 
> 
> The USB to ethernet ID is 0bda:8153. It's is original Realtek 8153 ID.
> It's impossible.
> 
> And ocp data are 0.
> No way to identify it's from dock.

Can you at least identify the dock?

Can you have a udev rule which matches on 0bda:8153, it then walks up
the tree and checks if it is part of the dock? And it is on the
expected port of the hub within the dock, and not a USB stick plugged
into the dock on some other port of the hub?

     Andrew