Date:   Wed, 5 Jan 2022 14:24:36 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     dledford@redhat.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/uverbs: Check for null return of kmalloc_array
Message-ID: <20220105182436.GA2855076@nvidia.com>
References: <20211231093315.1917667-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211231093315.1917667-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6VhoEw/ubgK/PUPX6Vh0t7sDM2++n+AvEFnssBoLwp5g1eldohRiNYAkA9vd?=
 =?us-ascii?Q?3X4/+SlPKjTVSpRFXW/6XjItoDDcawnBSaRxTSSmse/k9JmoMs2rcBDpg5hb?=
 =?us-ascii?Q?GZRWAT+m5sxN2aXaNVYkuCivsGAh97arHHk2vjNd5WpQqoVXJhBwySN7GUny?=
 =?us-ascii?Q?jQSqJANWg3PeHS5G3U26xyH6/RCeTqYLtVk8J9lxfnlmsj+IKE2QqDhlCfZJ?=
 =?us-ascii?Q?VtSKk9LCKF5U2q+GFMUlpR+tQ5lyoTTCMP/kmXjNCO3JtG3SeUlqRz5+c08H?=
 =?us-ascii?Q?5WfCzFJv9FKWTMoKy4Lx1MyA7aT2zZaqlxZfzxup3WDQl5CpkR29+XeF3lKK?=
 =?us-ascii?Q?rBjR0mMlOi9QOByE1Fx0mzt5dENAZDYafTS6pBMF70qQ1lu13435YwvXBfY7?=
 =?us-ascii?Q?nJicFWn5cgupvoC6tvliQ51N5K86wGwvUnZE8pxgDYcEtW6pbVGU2BVfVux3?=
 =?us-ascii?Q?HlaICWWGmm0qhYCoEpwn4SR90t/YeHOe1cVCXhUJl7dFALQMDXjiuhXRGMEm?=
 =?us-ascii?Q?fJ5oxqExESYYNJodX3it0YMgGqjUFpn1iZTQEh2zhGAQi0YONIPY0/EnRD2w?=
 =?us-ascii?Q?ROazzMil14ISZimkUpaXMrqzXnTOKMIHNlA6lI90Xrs+hF0w/8UA6jofIM4U?=
 =?us-ascii?Q?RiK5eFXERsvwdY7vQh9+0xTJFeDSK+b91F1d0aIAD4XjM2uV6/2VOkMGPobl?=
 =?us-ascii?Q?MFOeel+Z5vMiQrWO8GPLBtUa7XTceIg2rz8zmurDwOSrftXdH8I1+zAX09uT?=
 =?us-ascii?Q?XX9t7vqU3lt6zr/OOTjp7Lti9OC/0Emxrdg+foLWVgIYdUuYCElWGOAYuXBc?=
 =?us-ascii?Q?rVledcuJXWWViPOylZzOWNFkkeZtgaTt3Ti7ysenFPlLAtfQDfEF+J0cvGRF?=
 =?us-ascii?Q?0lxyXgKfF7tOBtBLdUDB8m7AQuzkClfPI2QRdgAu9GZj3wHFNhRfKIy7zwaG?=
 =?us-ascii?Q?PWu+Th2E1LJ6eLKKvMx2cp3QVOyXP+lhmp2K+qPW5Lg1ApsTU503+cjzy3/L?=
 =?us-ascii?Q?vfrBDpxoiwzpNBdh8ULdjM9I9gqZCfnhUcjuQMFDS1Gfq5BgnqQoulajGWJN?=
 =?us-ascii?Q?lwb9E8U34Vu586u9JwsLgyH9TujM1FPKaKP6yyfzga8SBpRxmFIRRds0/AU7?=
 =?us-ascii?Q?ug2kjguRXT4b4mV42gKdiGbPNqvqSxVNavBr7EjKbd0I0DITHDGDQpL46iLm?=
 =?us-ascii?Q?c0knBAcKUcbg3xTNAdji2DzWXNSGzC4Ia6s50t/mmt+pUl1fmcTtNMJ8HDKO?=
 =?us-ascii?Q?j4qsAUwP0SnEksFfOumyoVHu3Qmuuee13Plxu+LCRyw669Lno1B4+L00oBof?=
 =?us-ascii?Q?xQrJOGAyP2spOhNPdnbcE2kIWpdGqhhdi5lO5A8cIhERWzL1lzxcuqRcibju?=
 =?us-ascii?Q?O6Z8uCCL8ooT4IvUEOcHJTuYvjzUoDf6b3wRgB7K+q/sASMZKsZ+jUbzDLbs?=
 =?us-ascii?Q?K9Fhj+/nO7ojs/M3NOqTAo2+Vd9PavqSasFf/L0lDlNRwnRRWmiXZ7/pJ5qL?=
 =?us-ascii?Q?f1CaSCAfvmgzYT1VuOV1Xwi/5lFrZuRFMrWm7u2PHL864RzA/hwGItZxKk7x?=
 =?us-ascii?Q?aBYpgWGYkD7etTHB91k=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c326f2b-043a-4a51-1f05-08d9d078a224
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 18:24:38.7376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8LIg4a/3vvxQ2hE8+bhmpN8xjf9fyz7iSn/YKEsilqG9not5OshJ78Nrkvb3btxY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5189
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 31, 2021 at 05:33:15PM +0800, Jiasheng Jiang wrote:
> Because of the possible failure of the allocation, data might be NULL
> pointer and will cause the dereference of the NULL pointer later.
> Therefore, it might be better to check it and return -ENOMEM.
> 
> Fixes: 6884c6c4bd09 ("RDMA/verbs: Store the write/write_ex uapi entry points in the uverbs_api")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/core/uverbs_uapi.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to for-rc, thanks

Jason