Date:   Wed, 5 Jan 2022 12:41:20 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 18/40] KVM: SVM: Create a separate mapping for the
 GHCB save area
Message-ID: <YdXmUBHFytjrpZuY@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-19-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-19-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0V4NlFIEraBoTy5hpGuYGw/2WyAu+qqqsrHQxukfZhkP0acTvU/zXedvtHiF?=
 =?us-ascii?Q?eLBgLiX863y73TTm1n3yr9ZbsVqrQram4Bd/6Ct8bUgh16so6e8ZMWaBKMOj?=
 =?us-ascii?Q?YUzW/WJ8GxQUdlz+G98rhYWbwCz+rGuJ/N+JsVLbGjyFhJWzPCJbSX/SYzeo?=
 =?us-ascii?Q?k8z2QQiwbCQ2/lWzkwTCfPTcuU3KIlGPQOx6+k8g1SX6PqG+vkCALdhqpVks?=
 =?us-ascii?Q?C8lWeb0NgL/Bw4W6EZFt1Lzbs/yRKSwe7H6nS8thlM455D5Yc9EP7ooqIPtK?=
 =?us-ascii?Q?T/5wYyUyUGONVTsFgS9CYXw7jMsCLMQo0B8+uQs3iYa5Ipfaj0R5Tz/nqDqB?=
 =?us-ascii?Q?qzKbVS5ixG1VCXrR20GU4kdYmXePXl+vYFW6oi4aMKVowbh680KFgdLYQ7bw?=
 =?us-ascii?Q?5A1+Ow9VSoy789pNOq27B+HCBLMNZLXlHWshYkE2Ivcv/EHMi9m0xg6u2Y3H?=
 =?us-ascii?Q?ccIdpyHEqoQcAKOLdaKccD0wFQfE8z6Y7EEq2J4ez57vBpBR8CUeHbU6nYH9?=
 =?us-ascii?Q?TstpZOQBPuAYnmY6Ozb322sQeHZS01I7WePK7PUIWVTXmuOakE4uqCpgD2wx?=
 =?us-ascii?Q?3BraWqQ0AGJipZj+yXNg/KDpySYrqjeGCPdFYc6+5gbgca5rqMAoy6iY1N8w?=
 =?us-ascii?Q?hLZb2N4ZYYUgz5bzfeoYKZHumAT1+7soDyC6sQRnWQ6puXYwKOo3lYglO2f7?=
 =?us-ascii?Q?nFhBWEPOfVL7MrQFzf1qHA8HvxzdUuhs5TZL2YUvRuDRTNLflhNlgx79Cgqj?=
 =?us-ascii?Q?fb1ZSqt+xDVa0ybf3hCIlEGBGZv41Uza5wSCAeNRl4JV0eic+JJnbUIn50w2?=
 =?us-ascii?Q?B+/rGM9KROeTCoUHWoq009pNrxxoTF0mQCjKqKHGTS50iyU2fqjJmUbKz1Zc?=
 =?us-ascii?Q?oHZFy9AAAP1nfEBpVk0ibVNPQ8J02nYenCY6RleKw47mnRIBOHhNiG6j4+s8?=
 =?us-ascii?Q?aQWeP64opADz+RrAZreRFvjhF9/7pe0RQU9H0hI8lTMEqSoV9PPTYOwBex18?=
 =?us-ascii?Q?f2LxlKGCUGftxYP1XOG7Ufl9eSl5Xc2cI7E1mYAQAwRtb5Q06bPQUfkN9VjJ?=
 =?us-ascii?Q?U6896WvlQyhcthud0sSC5TTo75OFu7JlfAK05HAEQEdBJlCcL/R1nMkuMg+T?=
 =?us-ascii?Q?yPC8F10kZO/yXVCEkdtbN7ibgy7Q/LcJzpriRqPslwxj9NZQ1WuL4qtJKbVB?=
 =?us-ascii?Q?NbI4K6ETBFSkSdo5dzKarbrZAVygqS+SjueUg7A6eDDBeDcd61n7s94ilgIY?=
 =?us-ascii?Q?Pm/52SoV0p5AFNDBcq+6wyiPG6JACO7SVcQUjkHBYvrq57RBKTfCvmjE7cFO?=
 =?us-ascii?Q?Qpn+Mmw6p8QrEMRb1SNtSAoxw7epReKxAvBPhheMnhk6VB1TCNt3aqDtv7Ur?=
 =?us-ascii?Q?QcbRkqeAObKvwctUlIvBotd9IJEHkARZIQBPKlzRpmwCNzBN8A+a9FI3m/eh?=
 =?us-ascii?Q?vPVMqs8MlJ0AQlLJ17BXN+ujp6X4I/5ri/lSUjwQ4Ty6aqklA97JHi8voccW?=
 =?us-ascii?Q?/eK19/ehEYT2l8CJMHUwVBbPgb3szKsEQJBZFu+BTUapAoKNg7bmbnLNPD49?=
 =?us-ascii?Q?Dm6+CMneH8azmpck9n6Hzpbsoa5M+HKevKfA80cJQlQTX0+q+DXvY6LnER0X?=
 =?us-ascii?Q?C5Vj93rAiT416z/bM3tB91Hqp2B6jXPA9cT9QMPG6Zxkx5zt5jB5b4YKISPj?=
 =?us-ascii?Q?WrbYog=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce17f64-7bd3-48bf-9178-08d9d07afb14
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 18:41:26.9221
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bnq8hK3T1WZulPYkuS8IDgDrunZzNnOCtFc1BrdnVCzQmno/wWvrSMhDb0EA2TYMuM3EeSuN90+I4sUW8x/XdW8/uqWnhcVtrv//nxpnmHs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2702
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10218 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201050119
X-Proofpoint-ORIG-GUID: VgtPoetv1a6-v94L3EnkmPAqreWd6QyK
X-Proofpoint-GUID: VgtPoetv1a6-v94L3EnkmPAqreWd6QyK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:43:10 -0600, Brijesh Singh wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> The initial implementation of the GHCB spec was based on trying to keep
> the register state offsets the same relative to the VM save area. However,
> the save area for SEV-ES has changed within the hardware causing the
> relation between the SEV-ES save area to change relative to the GHCB save
> area.
> 
> This is the second step in defining the multiple save areas to keep them
> separate and ensuring proper operation amongst the different types of
> guests. Create a GHCB save area that matches the GHCB specification.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>

> ---
>  arch/x86/include/asm/svm.h | 48 +++++++++++++++++++++++++++++++++++---
>  1 file changed, 45 insertions(+), 3 deletions(-)
>