Date:   Wed, 5 Jan 2022 15:06:33 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Dust Li <dust.li@linux.alibaba.com>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/mlx5: print wc status on CQE error and
 dump needed
Message-ID: <20220105190633.GC2861973@nvidia.com>
References: <20211227123806.47530-1-dust.li@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211227123806.47530-1-dust.li@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LX4UZXWk/VvkZEZYt6d5yXo8tKHhKh4ZRBJS/SfVujo+fuWUGhiEY/OD46wp?=
 =?us-ascii?Q?1QTQltLUmYqHzyyo71FcpZnDNM3IGMApxcKLHm/Ivy3/5z1bDjlXC1kW4udz?=
 =?us-ascii?Q?5zcWg/fxEE4y+EjKdQzgI2VQnjsMyG4bV+ol4c4kQourSWgsr7V9UdPc+Csj?=
 =?us-ascii?Q?E/NEwNwGJ4pmeW+9FiOHLQbZzZ7tyDZj1JUdlhpffKejyIK36LwbACNfNxf7?=
 =?us-ascii?Q?Swqjd7Qk1e48SYPhByfDgiqsoDlaRF69455+3AJtBjTAJxrU8H0UkmSHPzYQ?=
 =?us-ascii?Q?XlRaxP6KEgTMQ/2dJSY2Iw8+GkLXJPmjfiZ1riBtBIFwxEu7DYCl/hXvlNIJ?=
 =?us-ascii?Q?mOvwkS31aGdDnZV82LZFB3vyYMwklXBBu4oAS7soc3+smg9NJZ0SFrNWfGJQ?=
 =?us-ascii?Q?wfsnkglSuHojPMvc1LJskBh3rp9UoJVFAQhgFSdbmAEdN3BNSxdlmIjVgeGN?=
 =?us-ascii?Q?X0yRTNYusO5qTtsU5bumMRIILWiruZUWxYjh0GbOiWXDlTJ90KVOxz2T7d/+?=
 =?us-ascii?Q?ZBwK4UVweRGuKOzl2IyZbm7NsJjLKs1ZDjyrtzQr2fcgWKmQHjilrndAjfon?=
 =?us-ascii?Q?er0/ruqdweZDwVexorunDPOfF0XnxVR7bh71flyEF6iH2AywV3YXdbYUVe82?=
 =?us-ascii?Q?joWUE6HUwLMObYvkFppVUCkLBl15nARcEev20UkX7kqWUJT3exXmuMlQPpGf?=
 =?us-ascii?Q?PClQq2zDOsGMsPCI/gSCMw9KzFbDBgPb8jIEL74lQudMi3CNxvcpG9KQ9kLt?=
 =?us-ascii?Q?vsxpySLKHWC2tMpnbjOltvQpIoR7dG5LB84zkdkQhansRhUwB7vwXZdEiG8l?=
 =?us-ascii?Q?1LR98788jdR/j7Z/GByIgXlcLLDvjgmumuupFaCZT0SVcCRBGM2SEtMFEoy7?=
 =?us-ascii?Q?2OxwkXoukdZbpV3J6+raE6fkgeolhYfrLVmL8/bUjeawu9kyfSDcykSriOW7?=
 =?us-ascii?Q?UZivE4K9pQVbRipNcWnEoDxtoujZMTPlk1sSXo0XJf5BW5YvUNmYcWYpnPON?=
 =?us-ascii?Q?aSyetlwsz+qffoM8HfT+nPalqFBcwzmV54IZwnKe8/GvLJNLLsvIhpgpTodE?=
 =?us-ascii?Q?a5dHJuLibDrh/8rgy/qPgedNm4tR5c549pkMmvCX2Hi4odtN3T2NkTusOVUE?=
 =?us-ascii?Q?vBQf/FOo3zojFPXHKILOTTL7giTRWglrC9thxCy3xeXLZQobMbhUQpSKVPIu?=
 =?us-ascii?Q?QhYApMtL2fSBIOElAvZy3KcDsEvoM2dWUWUM816JzTsGFArH1C81nlyr3QV/?=
 =?us-ascii?Q?JfRqBVEI7CvhDA//bvZ28BBxKgVY0FQlHbPVHTbQFsq2Vd+5W1cVew/KVeVb?=
 =?us-ascii?Q?ZdB1NFqvT6Z4BMbaA2DmsBbrMmiaYXzuBhbRIkywXvqWv+7sYbLLIUiXqAe1?=
 =?us-ascii?Q?UUfb1Jgh+Jrc1Ur3Vf94xfmDiyd0pfKr29K6VKRhja2FUzhHOzTCIpkf0Vx2?=
 =?us-ascii?Q?skcay2KX/JP/HLqvDRfphL/pJUbkspttraJhsMWzwWNQMXiD84jsLe30AaKk?=
 =?us-ascii?Q?mhpAtCwqClwc786Ahd7ttP4Br5IcthoK4xefJ6KPqlTTP6xEw50f0FZ6sVpn?=
 =?us-ascii?Q?bnby4SrOM+jrHVySrC8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afff5ff3-8744-47ca-e4cd-08d9d07e7f36
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 19:06:37.4176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6GmCAnHNuKCCg083kiVH7hVU2SpLXFwMfDZp+2LTLxwF+1wt8Ix4meavtrHtd/W8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5301
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 27, 2021 at 08:38:06PM +0800, Dust Li wrote:
> mlx5_handle_error_cqe() only dump the content of the CQE
> which is raw hex data, and not straighforward for debug.
> Print WC status message when we got CQE error and dump is
> need.
> 
> Here is an example of how the dmesg log looks like with this:
> [166755.330649] infiniband mlx5_0: mlx5_handle_error_cqe:333:(pid 0): WC error: 10, message: remote access error
> [166755.332323] infiniband mlx5_0: dump_cqe:272:(pid 0): dump error cqe
> [166755.332944] 00000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> [166755.333574] 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> [166755.334202] 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> [166755.334837] 00000030: 00 00 00 00 00 00 88 13 08 03 61 b3 1e a1 42 d3
> 
> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
> Acked-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/hw/mlx5/cq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied to for-next, thanks

Jason