Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates
 194.138.21.71 as permitted sender) receiver=protection.outlook.com;
 client-ip=194.138.21.71; helo=hybrid.siemens.com;
Date:   Wed, 5 Jan 2022 20:09:20 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Aaron Ma <aaron.ma@canonical.com>
CC:     Oliver Neukum <oneukum@suse.com>, <kuba@kernel.org>,
        <linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <davem@davemloft.net>,
        <hayeswang@realtek.com>, <tiwai@suse.de>
Subject: Re: [PATCH] Revert "net: usb: r8152: Add MAC passthrough support
 for more Lenovo Docks"
Message-ID: <20220105200920.7362a662@md1za8fc.ad001.siemens.net>
In-Reply-To: <fa192218-4fc8-678f-8b40-95b85e36097e@canonical.com>
References: <20220105155102.8557-1-aaron.ma@canonical.com>
 <394d86b6-bb22-9b44-fa1e-8fdc6366d55e@suse.com>
 <fa192218-4fc8-678f-8b40-95b85e36097e@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 19:09:25.4846
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ccbf267-1a29-47a8-39bc-08d9d07ee3c3
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.71];Helo=[hybrid.siemens.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT016.eop-EUR01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB2585
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Thu, 6 Jan 2022 00:05:28 +0800
schrieb Aaron Ma <aaron.ma@canonical.com>:

> On 1/6/22 00:01, Oliver Neukum wrote:
> >=20
> > On 05.01.22 16:51, Aaron Ma wrote: =20
> >> This reverts commit f77b83b5bbab53d2be339184838b19ed2c62c0a5.
> >>
> >> This change breaks multiple usb to ethernet dongles attached on
> >> Lenovo USB hub. =20
> >=20
> > Hi,
> >=20
> > now we should maybe discuss a sensible way to identify device
> > that should use passthrough. Are your reasons to not have a list
> > of devices maintainability or is it impossible?
> >  =20
>=20
> The USB to ethernet ID is 0bda:8153. It's is original Realtek 8153 ID.
> It's impossible.
>=20
> And ocp data are 0.
> No way to identify it's from dock.

Is that revert you giving up on the other one? Maybe these IDs offer a
way after all.

One of my offending devices is a idVendor=3D13b1, idProduct=3D0041 from
Linksys so probably clearly not Lenovo, was just plugged into a Lenovo
hub.

The other one is a idVendor=3D17ef, idProduct=3D7214 so actually a Lenovo
travel hub. And probably rightfully getting a pass-thru ... if we want
to keep that feature in the kernel and not push it out to udev (for all
vendors)

Anyhow, it seems like the revert is coming. And i will disable that
feature in the BIOS to be sure. But i will be happy to test further
patches.
=20
regards,
Henning


> Aaron
>=20
> >  =C2=A0=C2=A0=C2=A0 Regards
> >  =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver
> >  =20