Date:   Wed, 5 Jan 2022 15:49:10 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Leon Romanovsky <leonro@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/mad: Delete duplicated init_query_mad
 functions
Message-ID: <20220105194910.GC2872048@nvidia.com>
References: <af6f35c590ff5ef56d0137351b8b295af0f7c13c.1641369858.git.leonro@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <af6f35c590ff5ef56d0137351b8b295af0f7c13c.1641369858.git.leonro@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWY2d1l0UUIzL3pBR3NxYkhWK0YzbTY2Z1VmNG02YU0vdlFCQjFhNFNrRlYy?=
 =?utf-8?B?bnE2TlFMdkN1NE4rS1FvRFREaFZ2RmZraWU2andpTUhkajJVZW11NzdZSWxa?=
 =?utf-8?B?UGRNZFowZFYxZkZRMS9DZDF3YXFNY0lqNzNVMGZFQ29jT1YvZDRIemsxenc2?=
 =?utf-8?B?OFB1UmU3R21QVlBGbkdxT0d3eUZiUmZacUNYK2VYVzFHY3JjMFFWWUFqUldN?=
 =?utf-8?B?K3A0SHRWQVJOSEhxTHUzMVhMeENFTTd2S0xZY1kySTRNTC9vRXcrcUhNRTJT?=
 =?utf-8?B?cjNtSC9mdGhVMENCZFNMcHFQSUJZNHVNRXA2OWlOUXFtQWh5MGZSYlJoTEYw?=
 =?utf-8?B?eHRRelRycExGUHJzeFRBUE1idDczVFU2dzB2RHdvaGpLbVpHbm5qdCtVTEhv?=
 =?utf-8?B?aGU0RHN6VHdyL1pHT0E4QXJ4aURGeWREQUZHcHpnV2pmZmFvUmEyRHliVFVR?=
 =?utf-8?B?cDlXeUNXa1JQRW43VXM1UWlXNzk2M2NUOFRwT09reEM1alRacXRuc1l1aElL?=
 =?utf-8?B?SzU0QzNLQnI1dmg1dGNWdDlWY0luUC9jSTQ1djlsVk42bVltUFBUSnJMekwr?=
 =?utf-8?B?NUI3dFZZY0kzdmxTOS9uaFNKTEljbkpHM3RnVFJJK3dmZElhKzVhdWtuK0tr?=
 =?utf-8?B?ZlZvZGhVSmMwOUd1YmlRMXFjYmVkL3dyZldJaHlKcS9zTms3SithQmNrOVlS?=
 =?utf-8?B?UFhzeml0dG1MRTVVMWZWaktwc00zbnVvTm5TY2pOUVhVbVlJSm0vVEN2d1F0?=
 =?utf-8?B?dFBIUGtmcWdzNkZNdEpiL3pxV2tvbFB1Ukc4RlAwdmJ4UjZ4TWFjTzlXdkFN?=
 =?utf-8?B?elU4YnRGTGZ4SHd1MDcyZXRTeU5LOXNDMW0yTHdrSjZiejR3MWwxUnJURkd1?=
 =?utf-8?B?LzRrSFZXL2dQRTZ6U1hBaTY1eTZtbG84UnJiVnMyd3huNVhZLzVjeUJrSVo1?=
 =?utf-8?B?a2doaUVKTlM2UkNGa1lGNURsaWdVTCtqTVRoNUJ1VGxrWS9KZmFwR0h6anNL?=
 =?utf-8?B?Si9lRkordjlML21JMXB2QUY2TkFyQ3Z3ODBSVHAxVlF5ai85OUkyUkJucGNa?=
 =?utf-8?B?eGNyMDJtOUFscyszRzNibG1ncXhkTlZxa3JibVZQVVg5b2NvNDRqSUNIZWZj?=
 =?utf-8?B?L3VJRU9jby9GZ1JuVEo2VmozL241VGpMVnRXM21KSjZ1NjFsKzNKYmQ2L0ZJ?=
 =?utf-8?B?cEtaZlc4eTNHaENENGswUEQyZnVYRU1SeHpyN2plSWpZSkdycUdnbVdtTTZr?=
 =?utf-8?B?cEd1WG9kUC9KSTkxYXFXNmpjdG5zaWw0NEFZVlYrcmZlODRZL3QyM3pyOFFn?=
 =?utf-8?B?SGZiSXh3TEZkWlZ4RzQrYldyMEdHRSs1YkgvK3M3MkNpWjhnQXhZVHhwOGhF?=
 =?utf-8?B?aW44bDczT1VRZzdGK3g5Z3pxbUM2WU8ydGdOQk1GT2JLY0ZJY0w0dEo2Mnhx?=
 =?utf-8?B?ZWRGTnVxOHBVb1B2WVlvM1NrRTh5aUZzTlhxV3ZvM3oxbW93ZEdlekxlbmxo?=
 =?utf-8?B?RE1Ya3ErWGFaUkNJTDBOeEJxc3BTWk9ieHVaWG1pR1dxR2IzdXRKNDFiblhZ?=
 =?utf-8?B?TGNOaFQ1b0wwU0RxZlNac2E3YjM5b3l1a1pqRnI0KzUvaDRoM1hSNU5rRE5M?=
 =?utf-8?B?L0h0ZU1KbHo5L0hqci9mMWpsUUJvWGVZVXBUQlJ0WHp2dUNqZlViNmhzNkRj?=
 =?utf-8?B?MDYrS1pyRk5pRnl2TDlDQnFMOE1GRjFNMDQ0VDNoa1U2djYyRERzbWs4VEpN?=
 =?utf-8?B?eVpkNitiTmlGbG5qQkVSMGpzaUVLWWZaQ2JxcUVRSTRRRm15bWQrVG5sdjQr?=
 =?utf-8?B?dnBZNnhQNWx2RHU2YnpVT1pub3kya2NJWkRGbktPVVhtOGw2Q2FJQmVIQXc1?=
 =?utf-8?B?eDB4eXVCUDM3VXdBQTZUYjJNQk9ncEo1UnhvZlUxR2FvMkNBd1FUdmtwRnV0?=
 =?utf-8?B?SUwyN1FaakJJMzk0cjJTNGpIbXFWakJ5UW1sanRmVXptMmE4Nk9vc2IyRXBK?=
 =?utf-8?B?SXhITk4zVVRpMURkY3VxQ2puVE94UHR6bjRTT2lIMzNHcHorTndBV0xIWFZ1?=
 =?utf-8?B?YWhtcHFZWTNpZHhlenFWR3o2Tnh2OElYNnBJeStqNHQxc0l6c0Y2MFFjblpD?=
 =?utf-8?Q?jROw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da28c878-4a9c-41ba-f6fe-08d9d084729b
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 19:49:12.8438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7bPRaHm44GMDLSPg5R3BhpIMJsXigJoDTk0qoRO3sjMvD0QFoLKKQCiX1AC7KfD/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5031
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 05, 2022 at 10:04:56AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Several drivers used same function to initialize query MAD,
> so move that function to global header file.
> 
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
>  drivers/infiniband/hw/mlx4/main.c            | 24 +++++++-------------
>  drivers/infiniband/hw/mlx5/mad.c             | 18 +++++++--------
>  drivers/infiniband/hw/mlx5/mlx5_ib.h         |  8 -------
>  drivers/infiniband/hw/mthca/mthca_provider.c | 20 +++++-----------
>  include/rdma/ib_smi.h                        | 12 +++++++++-
>  5 files changed, 34 insertions(+), 48 deletions(-)

Applied to for-next, thanks

Jason