Message-ID: <28405360-ea08-acdd-d62b-b925c9904dff@google.com>
Date:   Wed, 5 Jan 2022 16:31:05 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [PATCH] rlimits: do not grab tasklist_lock for do_prlimit on
 current
Content-Language: en-US
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     Christian Brauner <christian.brauner@ubuntu.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexey Gladkov <legion@kernel.org>,
        William Cohen <wcohen@redhat.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Chris Hyser <chris.hyser@oracle.com>,
        Peter Collingbourne <pcc@google.com>,
        Xiaofeng Cao <caoxiaofeng@yulong.com>,
        David Hildenbrand <david@redhat.com>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20211213220401.1039578-1-brho@google.com>
 <8735mww2w3.fsf@email.froward.int.ebiederm.org>
 <456a056e-453e-71b0-0f9e-03511b9f56b1@google.com>
 <87zgp1psd3.fsf@email.froward.int.ebiederm.org>
From:   Barret Rhoden <brho@google.com>
In-Reply-To: <87zgp1psd3.fsf@email.froward.int.ebiederm.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/15/21 14:42, Eric W. Biederman wrote:
> In update_rlimit_cpu use lock_task_sighand instead of unconditionally
> grabbing sighand->siglock (because without tasklist_lock sighand might
> be NULL).

this ended up being a minor complication, since update_rlimit_cpu() 
could fail if the task was exiting, but i think i sorted it out.

i'll send out revised patchset shortly with this change, including 
making do_prlimit() static.

thanks,

barret