MIME-Version: 1.0
References: <20220105220653.122451-1-gwendal@chromium.org>
In-Reply-To: <20220105220653.122451-1-gwendal@chromium.org>
From:   Dmitry Torokhov <dtor@chromium.org>
Date:   Wed, 5 Jan 2022 14:50:19 -0800
Message-ID: <CAE_wzQ_DTnrU9QbADZuNyt4fszAiTwa04D9muC-xE_S3MM9eGQ@mail.gmail.com>
Subject: Re: [PATCH 00/17] Add export symbol namespace PL_CHROMEOS
To:     Gwendal Grignou <gwendal@chromium.org>
Cc:     bleung@chromium.org, groeck@chromium.org, myungjoo.ham@samsung.com,
        cw00.choi@samsung.com, benjamin.tissoires@redhat.com,
        jic23@kernel.org, hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
        lee.jones@linaro.org, pmalani@chromium.org, sre@kernel.org,
        thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
        lgirdwood@gmail.com, a.zummo@towertech.it, cychiang@chromium.org,
        perex@perex.cz, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Gwendal,

On Wed, Jan 5, 2022 at 2:07 PM Gwendal Grignou <gwendal@chromium.org> wrote:
>
> Add a symbol namespace for functions exported by the plaform chromeos
> subsystem.

It would be great to explain why this is needed/desirable. What are
the benefits of introducing this namespace? What problem are you
trying to solve?

> Add depenencies for all drivers using these function.
>
> 'make nsdeps' is used to fix the dependencies.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
>
> Gwendal Grignou (17):
>   plaform: chrome: Add PL_CHROMEOS export symbol namespace
>   iio:cros_ec_sensors: Add PL_CHROMEOS dependency

I wonder if ordering patches this way breaks compilation (patches
should be structured in such a way that one need not apply entire
series to get to buildable kernel). Isn't putting symbols into new
namespace makes them unavailable to modules unless they explicitly
import it?

Thanks.

-- 
Dmitry