MIME-Version: 1.0
References: <ADAFDE41-E3FC-4D96-A8D8-1DAEC56211E9@gmail.com>
In-Reply-To: <ADAFDE41-E3FC-4D96-A8D8-1DAEC56211E9@gmail.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 5 Jan 2022 15:50:36 -0800
Message-ID: <CAEf4BzY9=Eqs7QnSj0s9uf0_DySO=7ySYXsFzPg2uHKXTbScjg@mail.gmail.com>
Subject: Re: [Resource Leak] Missing closing files in tools/bpf/bpf_asm.c
To:     Ryan Cai <ycaibb@gmail.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        john fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 29, 2021 at 7:40 PM Ryan Cai <ycaibb@gmail.com> wrote:
>
> Dear Kernel maintainers,
>               1. In tools/bpf/bpf_asm.c, the file opened at Line 40 may not closed within the function?
>               Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/tools/bpf/bpf_asm.c#L40-L49
>
>               Should it be a bug? I can send patches for these.

file will be closed by the kernel on exit, but it would be better to
close it explicitly, so please feel free to send a fix

>
> Best,
> Ryan
>
>