Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211230150321.167576-1-colin.i.king@gmail.com>
References: <20211230150321.167576-1-colin.i.king@gmail.com>
Subject: Re: [PATCH] clk: socfpga: remove redundant assignment after a mask operation
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     kernel-janitors@vger.kernel.org, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org
To:     Colin Ian King <colin.i.king@gmail.com>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-clk@vger.kernel.org
Date:   Wed, 05 Jan 2022 16:33:17 -0800
User-Agent: alot/0.9.1
Message-Id: <20220106003318.E28E7C36AE9@smtp.kernel.org>
Precedence: bulk

Quoting Colin Ian King (2021-12-30 07:03:21)
> The assignment operation after a & mask operation is redundant, the
> variables being assigned are not used afterwards. Replace the &=3D
> operator with just & operator.
>=20
> Cleans up two clang-scan warnings:
> drivers/clk/socfpga/clk-gate.c:37:10: warning: Although the value stored
> to 'l4_src' is used in the enclosing expression, the value is never
> actually read from 'l4_src' [deadcode.DeadStores]
>                 return l4_src &=3D 0x1;
>                        ^         ~~~
> drivers/clk/socfpga/clk-gate.c:46:10: warning: Although the value stored
> to 'perpll_src' is used in the enclosing expression, the value is never
> actually read from 'perpll_src' [deadcode.DeadStores]
>                 return perpll_src &=3D 0x3;
>=20
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---

Applied to clk-next