Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B8A0C433EF for ; Thu, 6 Jan 2022 00:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344102AbiAFAyf (ORCPT ); Wed, 5 Jan 2022 19:54:35 -0500 Received: from smtp25.cstnet.cn ([159.226.251.25]:37752 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1344113AbiAFAww (ORCPT ); Wed, 5 Jan 2022 19:52:52 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-05 (Coremail) with SMTP id zQCowAA3FxRIPdZhGtmuBQ--.49966S2; Thu, 06 Jan 2022 08:52:24 +0800 (CST) From: Jiasheng Jiang To: gregkh@linuxfoundation.org Cc: mika.westerberg@linux.intel.com, andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: Re: Re: [PATCH] thunderbolt: Check for null pointer after calling kmemdup in icm_handle_event Date: Thu, 6 Jan 2022 08:52:23 +0800 Message-Id: <20220106005223.2480738-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowAA3FxRIPdZhGtmuBQ--.49966S2 X-Coremail-Antispam: 1UD129KBjvdXoW5Kw4kJr1fGFW8ZF15KrWDtwb_yoWxWwcE9r 4DGanIyw48GFWFy3W0kF4rXFW2kr42g3yYvw1Fqry3Gr98XaykWF9YgrsYvw1kAF4Sqr9I yr93XFW3X3429jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVWD MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JU3DG5UUUUU= X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 05, 2022 at 06:21:57PM +0800, Greg KH wrote: > I can not understand this changelog text at all, sorry. Please read the > documentation for how to write a good changelog text. Thanks, I will correct my changelog from now on. > And most importantly, how did you test this change? Actually, all I did is just to read the description of the kmemdup() and then add the check. I don't think it is necessary to test, for the patch is just to make the system more robust, but not to introduce a new function, which is needed to test to guarantee the normal operation. Anyway, there is a previous patch that has already fixed the bug. Sincerely thanks, Jiang